Merlin replaced with ark-transcript #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swasilyev for reference https://github.com/davxy/ring-proof/pull/3/files As you can see in my draft PR the Of course for JAM we'll specialize it to use ark-transcript. But, as said in the chat, I really like your ring lib to be not bound to a precise incarnation of transcript (as it is also generic for the curve) as it may be useful for other applications and people may want to use their stuff. We 💕 generic transcripts 💕 |
burdges
approved these changes
Sep 5, 2024
|
I think users can provide their implementation w/o extra feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only thing that we've decided for sure in w3f that we don't want merlin due to limited implementations and being tricky to specify. So so far as the simplest solution we have @burdges' ark-transcript.