Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take references where allowed and re-exports #25

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Conversation

davxy
Copy link
Collaborator

@davxy davxy commented Jul 10, 2024

  • Take by reference where allowed (prevents clone in downstream users)
  • Re-export fflonk and merlin as the user needs them anyway
  • Propagate asm feature to ark-ff

@davxy davxy requested review from burdges and swasilyev July 10, 2024 18:05
ring/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@burdges burdges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just choose if you want to rexport form the root like people usually do, or use prelude because you always need both.

@@ -1,4 +1,5 @@
[workspace]
resolver = "2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently not when you use a workspace:

warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver
 = "2"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions

Copy link
Collaborator

@swasilyev swasilyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davxy davxy merged commit 665f5f5 into w3f:master Jul 23, 2024
4 checks passed
@davxy davxy deleted the nitpicks branch July 23, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants