Skip to content

Commit

Permalink
common::Transcript renamed to PlonkTranscript
Browse files Browse the repository at this point in the history
  • Loading branch information
swasilyev committed Sep 6, 2024
1 parent 12c0ed5 commit 5d0439d
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 14 deletions.
6 changes: 3 additions & 3 deletions common/src/prover.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@ use fflonk::pcs::PCS;

use crate::piop::ProverPiop;
use crate::Proof;
use crate::transcript::Transcript;
use crate::transcript::PlonkTranscript;

pub struct PlonkProver<F: PrimeField, CS: PCS<F>, T: Transcript<F, CS>> {
pub struct PlonkProver<F: PrimeField, CS: PCS<F>, T: PlonkTranscript<F, CS>> {
// Polynomial commitment scheme committer's key.
pcs_ck: CS::CK,
// Transcript,
// initialized with the public parameters and the commitments to the precommitted columns.
transcript_prelude: T,
}

impl<F: PrimeField, CS: PCS<F>, T: Transcript<F, CS>> PlonkProver<F, CS, T> {
impl<F: PrimeField, CS: PCS<F>, T: PlonkTranscript<F, CS>> PlonkProver<F, CS, T> {
pub fn init(pcs_ck: CS::CK,
verifier_key: impl CanonicalSerialize, //TODO: a type,
empty_transcript: T) -> Self {
Expand Down
2 changes: 1 addition & 1 deletion common/src/transcript.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use rand_core::RngCore;

use crate::{ColumnsCommited, ColumnsEvaluated};

pub trait Transcript<F: PrimeField, CS: PCS<F>>: Clone {
pub trait PlonkTranscript<F: PrimeField, CS: PCS<F>>: Clone {
fn add_protocol_params(&mut self, domain: &GeneralEvaluationDomain<F>, pcs_raw_vk: &<CS::Params as PcsParams>::RVK) {
self._add_serializable(b"domain", domain);
self._add_serializable(b"pcs_raw_vk", pcs_raw_vk);
Expand Down
6 changes: 3 additions & 3 deletions common/src/verifier.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@ use rand_core::RngCore;

use crate::{ColumnsCommited, ColumnsEvaluated, Proof};
use crate::piop::VerifierPiop;
use crate::transcript::Transcript;
use crate::transcript::PlonkTranscript;

pub struct PlonkVerifier<F: PrimeField, CS: PCS<F>, T: Transcript<F, CS>> {
pub struct PlonkVerifier<F: PrimeField, CS: PCS<F>, T: PlonkTranscript<F, CS>> {
// Polynomial commitment scheme verifier's key.
pcs_vk: CS::VK,
// Transcript,
// initialized with the public parameters and the commitments to the precommitted columns.
transcript_prelude: T,
}

impl<F: PrimeField, CS: PCS<F>, T: Transcript<F, CS>> PlonkVerifier<F, CS, T> {
impl<F: PrimeField, CS: PCS<F>, T: PlonkTranscript<F, CS>> PlonkVerifier<F, CS, T> {
pub fn init(pcs_vk: <CS::Params as PcsParams>::VK,
verifier_key: &impl CanonicalSerialize,
empty_transcript: T) -> Self {
Expand Down
2 changes: 1 addition & 1 deletion ring/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ pub fn hash_to_curve<A: AffineRepr>(message: &[u8]) -> A {
#[derive(Clone)]
pub struct ArkTranscript(ark_transcript::Transcript);

impl<F: PrimeField, CS: PCS<F>> common::transcript::Transcript<F, CS> for ArkTranscript {
impl<F: PrimeField, CS: PCS<F>> common::transcript::PlonkTranscript<F, CS> for ArkTranscript {
fn _128_bit_point(&mut self, label: &'static [u8]) -> F {
self.0.challenge(label).read_reduce()
}
Expand Down
6 changes: 3 additions & 3 deletions ring/src/ring_prover.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use ark_ff::PrimeField;
use fflonk::pcs::PCS;

use common::prover::PlonkProver;
use common::transcript::Transcript;
use common::transcript::PlonkTranscript;

use crate::piop::{FixedColumns, PiopProver, ProverKey};
use crate::piop::params::PiopParams;
Expand All @@ -14,7 +14,7 @@ where
F: PrimeField,
CS: PCS<F>,
Curve: SWCurveConfig<BaseField=F>,
T: Transcript<F, CS>,
T: PlonkTranscript<F, CS>,
{
piop_params: PiopParams<F, Curve>,
fixed_columns: FixedColumns<F, Affine<Curve>>,
Expand All @@ -28,7 +28,7 @@ where
F: PrimeField,
CS: PCS<F>,
Curve: SWCurveConfig<BaseField=F>,
T: Transcript<F, CS>,
T: PlonkTranscript<F, CS>,
{
pub fn init(prover_key: ProverKey<F, CS, Affine<Curve>>,
piop_params: PiopParams<F, Curve>,
Expand Down
6 changes: 3 additions & 3 deletions ring/src/ring_verifier.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use fflonk::pcs::{PCS, RawVerifierKey};

use common::domain::EvaluatedDomain;
use common::piop::VerifierPiop;
use common::transcript::Transcript;
use common::transcript::PlonkTranscript;
use common::verifier::PlonkVerifier;

use crate::piop::{FixedColumnsCommitted, PiopVerifier, VerifierKey};
Expand All @@ -17,7 +17,7 @@ where
F: PrimeField,
CS: PCS<F>,
Curve: SWCurveConfig<BaseField=F>,
T: Transcript<F, CS>,
T: PlonkTranscript<F, CS>,
{
piop_params: PiopParams<F, Curve>,
fixed_columns_committed: FixedColumnsCommitted<F, CS::C>,
Expand All @@ -29,7 +29,7 @@ where
F: PrimeField,
CS: PCS<F>,
Curve: SWCurveConfig<BaseField=F>,
T: Transcript<F, CS>,
T: PlonkTranscript<F, CS>,
{
pub fn init(verifier_key: VerifierKey<F, CS>,
piop_params: PiopParams<F, Curve>,
Expand Down

0 comments on commit 5d0439d

Please sign in to comment.