-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amendment related to https://github.com/w3f/Grant-Milestone-Delivery/pull/1175 #2305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to the evaluation w3f/Grant-Milestone-Delivery#1175
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AltiMario is there any specific reason for skipping the docker deliverable?
hi @takahser in milestone 1 we included a docker deliverable. |
Hey @AltiMario , I'd appreciate it if you could provide me some answers to the comments I raised. Thanks. |
I'm expressing some urgency, as this PR is a prerequisite to continuing the milestone evaluation. @AltiMario |
sure thing @PieWol I will write it in a few minutes. Thanks |
Hi @PieWol sorry for the delay in my reply. 1- "Is it correct that you have, instead of creating your own web-based wallet, integrated Talisman to be usable for Tuxedo and your dApp?" Yes. We pivoted this part of the project following the suggestion of Joshua Orndorff. I added some extra info in the "Additional Information" section of milestone 1. 2- "Please adjust some links of this milestone to better fit the original application and its specifications for the deliverables. Right now the wallet readme isn't even mentioned in the documentation deliverable. Even though I think this is the key documentation for this milestone." I completely updated the README file to better describe the changes done, but I forgot to add it to the file of milestone 1. I'm going to add the link. 3- "The demo for showcasing the Talisman wallet compatibility seems cut short. In the readme only a 4 second clip is visible." 4- "We will provide [...] a basic tutorial that explains how a user can use the web wallet app for Tuxedo (Private key configuration, local URI to be used to connect to blockchain) and send test transactions, tuxedo balance, which will show how the new functionality works. Because it is not needed a tutorial of how to use Talisman we haven't done it. However, we created a basic video tutorial (3 parts) on how to use the extended CLI-wallet. 5- "Was listed as the specification for this deliverable. Yet in the milestone delivery you are linking to a little showcase video that walks through an offer creation and buying process. No info on private key configuration or how information from the chain is retrieved. It's just a video of a frontend usage." The Talisman integration doesn't cover the private key configuration but the extended CLI-wallet does. 6- "Is there no written article at all?", "Especially interesting could be a written article that covers your changes to Talisman to be Tuxedo compatible on a high level." Sorry, I didn't link them properly. Now you can see it in the README and in milestone 1 (section documentation and article). We produced documentation for: APIs spreadsheet, Build and run the project, DApp specification, Frontend development libs, Game design, Talisman wallet, Wireframes, Comparative analysis "CryptoKitties Development: A comparative analysis between EVM - Cardano - Tuxedo/Polkadot" 7- "Furthermore what exactly are you referring to by "webservice"? Is this supposed to be your dApp?" |
@AltiMario , Finally, what is the work you did to make Talisman work with Tuxedo? I thought Tuxedo / UTXO wasn't supported. Is there any code you had to modify on Talismans side or are you somehow making this work with blind signing? If you can please provide me a link to the code. |
hi @PieWol we used the blind signing, no work was done on the Talisman codebase. |
Hey @AltiMario , |
@AltiMario , |
hi @PieWol about your comment #2305 (comment) I don't know what I missed in this reply #2305 (comment) |
@PieWol I think there is a misunderstanding of the PR amendment scope. It is not for reduced work or just for the Talisman integration. It is also for the CLI-wallet extension, which took @NadigerAmit almost 2 months to build. It is a lot of work, probably a bit hidden (?), but that was a mandatory thing to do in order to have the DApp working. We exposed the functions built for the CLI-wallet as APIs of the webservice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AltiMario ,
please excuse my misunderstanding. I was under the false impression that the cli-wallet extension was already part of the application previous to the amendment. This amendment looks good to me. Thanks for your swift replies and I'm sorry for the inconvenience.
Hi @PieWol, don't worry, it didn't cause any inconvenience. I'm glad the work has been approved. We have a common goal, to create value for this ecosystem. |
Project Abstract
Develop a Tuxedo Web Wallet and Dapp.
Our goal is to showcase the potential of Polkadot using the UTXO paradigm for the end user, leveraging Tuxedo. The project will consist of two key stages:
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)