Dotflow Milestone 1 delivery

[Szegoo]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1657

[keeganquigley]

Thanks @Szegoo for your work and for working with the external evaluator. For reference, here is the full evaluation.

Once the evaluation is marked as accepted I will merge the it with the delivery and submit your invoice for payment.

I would only add that I found more clippy warnings about redundant closures if you can look at fixing these for the next milestone. Thanks!

warning: redundant closure
   --> contracts/identity/lib.rs:257:46
    |
257 |                 .map_or(Err(Error::IdentityDoesntExist), |v| Ok(v))?;
    |                                                          ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
    = note: `#[warn(clippy::redundant_closure)]` on by default

warning: redundant closure
   --> contracts/identity/lib.rs:308:65
    |
308 |                 self.identity_of.get(caller).map_or(Err(Error::NotAllowed), |v| Ok(v))?;
    |                                                                             ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

warning: redundant closure
   --> contracts/identity/lib.rs:330:65
    |
330 |                 self.identity_of.get(caller).map_or(Err(Error::NotAllowed), |v| Ok(v))?;
    |                                                                             ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

warning: redundant closure
   --> contracts/identity/lib.rs:352:65
    |
352 |                 self.identity_of.get(caller).map_or(Err(Error::NotAllowed), |v| Ok(v))?;
    |                                                                             ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

warning: redundant closure
   --> contracts/identity/lib.rs:370:65
    |
370 |                 self.identity_of.get(caller).map_or(Err(Error::NotAllowed), |v| Ok(v))?;
    |                                                                             ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

warning: redundant closure
   --> contracts/identity/lib.rs:419:41
    |
419 |                 .map_or(Err(Error::InvalidNetwork), |v| Ok(v))?;
    |                                                     ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

warning: redundant closure
   --> contracts/identity/lib.rs:470:65
    |
470 |                 self.identity_of.get(caller).map_or(Err(Error::NotAllowed), |v| Ok(v))?;
    |                                                                             ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

warning: redundant closure
   --> contracts/identity/lib.rs:513:46
    |
513 |                 .map_or(Err(Error::IdentityDoesntExist), |v| Ok(v))?;
    |                                                          ^^^^^^^^^ help: replace the closure with the function itself: `Ok`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

warning: `identity` (lib) generated 8 warnings (run `cargo clippy --fix --lib -p identity` to apply 8 suggestions)
    Finished dev [unoptimized + debuginfo] target(s) in 7m 05s

[Szegoo]

@keeganquigley Sorry for the clippy warnings. Fixed them and added a CI check to ensure we always notice them from now on. TheDotflow/dotflow-ink#46

[keeganquigley]

Thank you! Also @Szegoo, a minor note in the meantime, I'm getting a 404 error on the Docker build for the contract link, if you can fix that. Other than that all links work.

[Szegoo]

I'm getting a 404 error on the Docker build for the contract link, if you can fix that.

Should be good now 👍

[keeganquigley]

Thanks @Szegoo congrats on passing the milestone! For full disclosure, I updated the application link so that GH actions can correctly parse it.

[github-actions]

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation’s guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

[Szegoo]

Hello @keeganquigley, hope you are doing well.

It has been two weeks since our Milestone delivery got accepted. In the README file, it is mentioned that the payments are usually processed within two weeks so I would just like to ensure that there is no issue with the invoice we submitted.

[keeganquigley]

Hi @Szegoo thanks for inquiring. Yes, I can confirm that typically payments are processed within two weeks. I reviewed your invoice again and it looks good. I see that I forwarded your invoice to our operations team 10 days ago, so subtracting the weekend would be 8 business days so far. So hopefully the payment should arrive in the next couple days, and you will be notified here. If you don't receive it by the middle of next week let me know and I will ping the team. Thanks!