zeropool-2-snjax

[snjax]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• In case of acceptance, the payment will be transferred to the BTC/ETH payment address provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#208

[Noc2]

Thanks for the delivery. We will look into it as soon as possible.

[semuelle]

Hey @snjax, milestone deliveries should use the delivery template (you used our evaluation template) and go into the deliveries folder. Could you fix that, please?

[mmagician]

Let me know once you've got the tutorial ready, so I know where to start! I guess a lot has changed since Milestone 1.

[mmagician]

@snjax I had a quick look at your delivery. I'm still waiting for the complete tutorial.
In addition, there is no deliverable showing how your libraries integrate with substrate. According to your initial grant application:

We will create a library for proving and verifying private transactions, compatible with the substrate pallet

The compatibility is not yet demonstrated in this milestone.

[snjax]

@mmagician, our current implementation is compatible with substrate, we use no_std rust for parts of fawkes-crypto, used to implement the substrate module (like final field math).

I could show you the substrate module as part of milestone 3 this month.

Also, currently, we have a live EVM version on kovan with custom, not EVM-specific ABI.

We are working on a substrate module, supporting this ABI.

[mmagician]

@snjax I see your point that since your library is no_std compatible, the integration with substrate would be straightforward. However, since that integration is not explicitly demonstrated in M2, it might be easier to wait for M3 as you suggest and assess both milestones in parallel. What do you think?

[snjax]

@mmagician, assessing both milestones in parallel would be much more convenient for us.

[alxs]

@snjax just checking in, when do you think you'll be able to deliver M3?

[snjax]

@alxs the work is in progress. We were focused on more common non-substrate-specific points.

Here is current WIP repository for substrate. It seems this month we are able to show you the final result (like our evm kovan testnet).

[semuelle]

It seems this month we are able to show you the final result (like our evm kovan testnet).

Could you provide an update, @snjax? Does it make sense to keep this PR open if you want to finish and submit M3 alongside?

[snjax]

@semuelle We have built it. Here is the screencast of deposit, transfer, and withdrawal implemented on substrate tech stack and ZeroPool circuit.

Now we are working on documentation and deployment.

I will push an update into this PR soon.

[semuelle]

Hey @snjax, we are still waiting for an update from your side. How is it looking, any news since your last comment?

[snjax]

Hi, @semuelle . We have deployed the testnet at https://substrate.testnet.console.v2.zeropool.network/ . Currently, we are finalizing the documentation of the project.

[snjax]

@semuelle We have updated the milestone delivery. So, please, have a look and we are waiting for your feedback.

[mmagician]

@snjax Apologies for taking so long. I've created a first version of the evaluation in this PR, where you'll find the comments I have so far.

[semuelle]

ping @snjax

[snjax]

@semuelle We received your comments and working on documentation now. You will get the update in August.

[alxs]

@snjax friendly reminder - when do you think you'll be able to get back to us?

[Noc2]

@snjax I just wanted to check in regarding the current status. Would you still like to finish the delivery?

[Noc2]

(see above)

[snjax]

@Noc2 More substrate-specific documentation is added here.

We are currently working on switching to Plonk. But Groth16 implementation is stable.

Sure, I would like to finish the delivery.

[snjax]

@Noc2 @alxs Have you viewed the documentation? Have you got any comments?

We added Plonk support to our prover.

[semuelle]

Have you viewed the documentation? Have you got any comments?

Thanks for the ping. alxs has left and @Noc2 is currently ooo, but someone from our team is going to review it soon.

[snjax]

@semuelle

the current video of using the frontend of our pallet is available here https://www.youtube.com/watch?v=YRJadaIrBJs

The web interface is deployed at https://substrate.testnet.console.v2.zeropool.network/

[semuelle]

Hi @snjax. Sorry for the long pause. I have now started reviewing your delivery.
When I run the ZeroPool node through docker (docker-compose -f docker-compose.full.yml up), the relayer stops with the following error message. Do you know what might be the reason?

relayer_polkadot    | thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/params.rs:30:36
relayer_polkadot    | note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
relayer_polkadot    | /app/zp-relayer/pool.js:32
relayer_polkadot    |         this.treeParams = libzeropool_rs_node_1.Params.fromFile('./params/tree_params.bin');
relayer_polkadot    |                                                        ^
relayer_polkadot    | 
relayer_polkadot    | Error: internal error in Neon module: called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
relayer_polkadot    |     at new Pool (/app/zp-relayer/pool.js:32:56)
relayer_polkadot    |     at Object.<anonymous> (/app/zp-relayer/pool.js:196:16)
relayer_polkadot    |     at Module._compile (node:internal/modules/cjs/loader:1103:14)
relayer_polkadot    |     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1155:10)
relayer_polkadot    |     at Module.load (node:internal/modules/cjs/loader:981:32)
relayer_polkadot    |     at Function.Module._load (node:internal/modules/cjs/loader:822:12)
relayer_polkadot    |     at Module.require (node:internal/modules/cjs/loader:1005:19)
relayer_polkadot    |     at require (node:internal/modules/cjs/helpers:102:18)
relayer_polkadot    |     at Object.<anonymous> (/app/zp-relayer/utils/redisFields.js:15:16)
relayer_polkadot    |     at Module._compile (node:internal/modules/cjs/loader:1103:14)
relayer_polkadot    | error Command failed with exit code 1.
relayer_polkadot    | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
relayer_polkadot exited with code 1
``

[snjax]

@semuelle

This is because you run it with no parameters like proving and verifying keys.

We added the description of parameters into the README of zeropoolnetwork/zeropool-substrate.

Also, you can get it from here.

[semuelle]

We added the description of parameters into the README of zeropoolnetwork/zeropool-substrate.

The path to the params folder in the docker-compose file wasn't quite right, but I got it to work.

Unless I'm overlooking something, the article is still missing for both milestones. Could you still do that and update the delivery doc? Since you are submitting both milestones at once, one would be enough.

[semuelle]

ping @snjax

[snjax]

@semuelle We have published the overview&tutorial how to use ZeroPool privacy engine on substrate tech stack.

https://medium.com/zeropool/zeropool-implementing-privacy-preserving-transactions-with-zksnarks-and-substrate-1bd060505166

[snjax]

@semuelle We have published the overview&tutorial how to use ZeroPool privacy engine on substrate tech stack.

https://medium.com/zeropool/zeropool-implementing-privacy-preserving-transactions-with-zksnarks-and-substrate-1bd060505166

[semuelle]

Thanks, @snjax. I am happy to report that both or your milestones are hereby finally accepted. See evaluation notes here and here.

You will probably have to resend your invoices, as they require a somewhat recent date on them. :)

[snjax]

@semuelle Thanks for accepting all milestones.
It's not very clear to me, what you mean.
If you write about the accessibility of 0xb6F9F891497C0B72a8A817f3D3E3C721fca6f9CC in the submission there are no changes from my side and I have not sent any other invoices.

[semuelle]

@snjax, someone submitted an invoice through the invoice form the same day this PR was submitted.

• The invoice is only for M2, we don't have one for M1.
• The invoice is from Dec 2021. Could you send one with a more recent date?
• Also, the payment address doesn't match the application. Both addresses must match, so you either have to change it in the invoice (easiest) or submit an amendment to the contract.

[snjax]

@semuelle the invoice for Milestones 1 and 2 is sent.

[fededubbi]

Hi @snjax,

Could you please add your complete address under your name?

Many thanks,
Federica

[snjax]

@fededubbi, I have updated the invoice with the information you requested.

[RouvenP]

hi @snjax we transferred the payment today

[snjax]

@semuelle Thank you for the experience of cooperation with Web3 Foundation team. It was amazing. Btw, are you at EthCC? It would be nice to meet up.

[Noc2]

Hi @snjax, @semuelle is currently OOO and not at EthCC, but @bhargavbh from the Web3 Foundation might be there. Other than that, feel free to reach out via email: [email protected] and we can potentially schedule a call.

[snjax]

@Noc2 thank you for your reply. I will send email.