From 8297f7808da67fe8e19ad06ef2e82d1e271b0b9a Mon Sep 17 00:00:00 2001 From: Dastan <88332432+dastansam@users.noreply.github.com> Date: Sun, 25 Jun 2023 23:45:54 +0300 Subject: [PATCH] Update sirato_1_dastansam.md --- evaluations/sirato_1_dastansam.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/evaluations/sirato_1_dastansam.md b/evaluations/sirato_1_dastansam.md index ca425ce9a..12eeed0e6 100644 --- a/evaluations/sirato_1_dastansam.md +++ b/evaluations/sirato_1_dastansam.md @@ -22,9 +22,13 @@ In general, it's documented well and majority of the instructions are clear. Cod When installing the dependencies, I couldn't do it with simple `npm install` command, I had to force install the dependencies with `npm install --force`. I am not completely sure if it's because of some upstream issues with npm or dependencies, but I think it should either be fixed to work with `npm install` or documented that it should be installed with `npm install --force`. +### Explorer running locally + +Explorer local run + ### Code suggestions -I noticed that `.env` file is not gitignored. It's not a big deal, but it's better to keep it out of the repository. You can set the environment variables in the `.env` file in `.env.example` and use it as a fallback file. +I noticed that `.env` file is not gitignored. It's not a big deal, but it's better to keep it out of the repository. You can set the environment variables in the `.env` file in `.env.example` and use it as a fallback file to `.env`. `.env` should be used for production variables, I think. ### Logs @@ -274,4 +278,4 @@ explorer-ui | 2023/06/25 20:24:49 [emerg] 30#30: io_setup() faile explorer-ui | 2023/06/25 20:24:49 [emerg] 24#24: io_setup() failed (38: Function not implemented) ``` - \ No newline at end of file +