From 5130a3932f858e83d519791b66c1bb0f4478b233 Mon Sep 17 00:00:00 2001
From: Piet <75956460+PieWol@users.noreply.github.com>
Date: Mon, 27 May 2024 12:43:31 +0200
Subject: [PATCH] Hyperfridge m3 evaluation (#1183)

* init eval

* application fix

* update links

* update eval

* update eval - accepted

* init eval

* unit testing

* review documentation

* testing issues

* update

* update eval

* accepted
---
 evaluations/hyperfridge_3_piewol.md | 83 +++++++++++++++++++++++++++++
 1 file changed, 83 insertions(+)
 create mode 100644 evaluations/hyperfridge_3_piewol.md

diff --git a/evaluations/hyperfridge_3_piewol.md b/evaluations/hyperfridge_3_piewol.md
new file mode 100644
index 000000000..d23f7d2ca
--- /dev/null
+++ b/evaluations/hyperfridge_3_piewol.md
@@ -0,0 +1,83 @@
+# Evaluation
+
+
+- **Status:** accepted
+- **Application Document:** [Hyperfridge](https://github.com/w3f/Grants-Program/blob/master/applications/hyperfridge.md)
+- **Milestone:** 3
+- **Previously successfully merged evaluation:** All by PieWol
+
+| Number | Deliverable | Accepted | Link | Evaluation Notes |
+| ----- | ----------- | ------ | ------------- | ------ |
+| 0a. | License | <ul><li>[x] </li></ul> |  [Link to License](https://github.com/element36-io/ocw-ebics/blob/main/LICENSE) | Apache 2.0
+| 0b. | Documentation | <ul><li>[x] </li></ul> | [Link to Documentation Root](https://github.com/element36-io/ocw-ebics/blob/main/README.md) | works |
+| 0c. | Testing Guide | <ul><li>[x] </li></ul> | See [Testing Guide](https://github.com/element36-io/ocw-ebics/blob/main/INSTRUCTIONS.md)| works |
+| 0d. | Docker | <ul><li>[x] </li></ul> | [Docker](https://hub.docker.com/r/e36io/ebics-ocw/tags), see main README how to use | works |
+| 1. | Integrate Receipt | <ul><li>[x] </li></ul> |  [Repo](https://github.com/element36-io/ocw-ebics/blob/main/pallets/fiat-ramps/src/lib.rs#L1041)| |
+| 2. | fiat-ramp pallet | <ul><li>[x] </li></ul> |  [Pallet](https://github.com/element36-io/ocw-ebics/tree/main/pallets/fiat-ramps) | |
+| 3. | Unit Tests | <ul><li>[x] </li></ul> | [Unit Tests](https://github.com/element36-io/ocw-ebics/blob/main/pallets/fiat-ramps/src/tests.rs)| all passing|
+
+## General Notes
+I appreciate it that you are including specific links to the tools used within your testing guide. E.g. the polkadot-js link which is already specific to the local chain aswell as the api site for ebics-service.
+
+The chain also works with the provided docker file. 
+
+
+## Testing Guide
+Thanks for the updates so far. It works now with the remote API. Previously when trying to use the local api it threw this error:
+```
+{
+  "timestamp": "2024-05-27T08:29:04.875+00:00",
+  "status": 500,
+  "error": "Internal Server Error",
+  "message": "",
+  "path": "/ebics/api-v1/createOrder"
+}
+```
+
+Within the testing guide you are mixing the IBANs between minting and burning tokens from ALICE. I wonder why that is the case?
+
+First ``CH1230116000289537320`` then in the unpeg process ``CH1230116000289537312`` is used.
+
+Furthermore when trying to query the funds from chain state for Alice's IBAN after the mint event succeeded the balances for this IBAN remain 0 even though the event visible in the exlorer tab states that the mint to this IBAN was successful. The actual token balances are changing as expected though. Just within the fiat-ramps pallet the storage to keep track of the balance doesn't seem to be changed.
+
+```
+{
+  iban: CH2108307000289537320
+  balance: 0
+  lastUpdated: 1,716,797,490,005
+}
+```
+
+
+
+
+## unit tests
+<details>
+<summary> unit test output </summary>
+
+    running 15 tests
+    test mock::__construct_runtime_integrity_test::runtime_integrity_tests ... ok
+    test tests::should_fail_to_update_api_url_non_sudo ... ok
+    test tests::set_risc0_image_id ... ok
+    test tests::process_statements_is_permissioned ... ok
+    May 21 15:22:28.274 ERROR runtime::timestamp: `pallet_timestamp::UnixTime::now` is called at genesis, invalid value returned: 0    
+    May 21 15:22:28.274 ERROR runtime::timestamp: `pallet_timestamp::UnixTime::now` is called at genesis, invalid value returned: 0    
+    May 21 15:22:28.274 ERROR runtime::timestamp: `pallet_timestamp::UnixTime::now` is called at genesis, invalid value returned: 0    
+    test tests::test_iban_mapping ... ok
+    test utils::test_unpeg_request ... ok
+    test tests::should_make_http_call_and_parse ... ok
+    May 21 15:22:28.331 ERROR runtime::timestamp: `pallet_timestamp::UnixTime::now` is called at genesis, invalid value returned: 0    
+    May 21 15:22:28.331 ERROR runtime::timestamp: `pallet_timestamp::UnixTime::now` is called at genesis, invalid value returned: 0    
+    May 21 15:22:28.331 ERROR runtime::timestamp: `pallet_timestamp::UnixTime::now` is called at genesis, invalid value returned: 0    
+    test tests::test_burn_request ... ok
+    test tests::test_queue_empty_statement ... ok
+    test tests::test_queue_invalid_transactions ... ok
+    test tests::test_queue_incoming_transactions ... ok
+    test tests::test_queue_outgoing_transactions ... ok
+    test tests::test_queue_multiple_statements_outgoing ... ok
+    test tests::test_queue_multiple_statements ... ok
+    test tests::test_verify_queued_statements_works ... ok
+
+    test result: ok. 15 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 4.42s 
+
+</details>
\ No newline at end of file