From 1a35d47544126c7172a8be5ecc93b11e63fa318e Mon Sep 17 00:00:00 2001 From: Keegan | W3F <35080151+keeganquigley@users.noreply.github.com> Date: Tue, 5 Dec 2023 17:21:11 -0500 Subject: [PATCH] Update plutonication_1_keeganquigley.md --- evaluations/plutonication_1_keeganquigley.md | 82 +++++++++++++++++--- 1 file changed, 71 insertions(+), 11 deletions(-) diff --git a/evaluations/plutonication_1_keeganquigley.md b/evaluations/plutonication_1_keeganquigley.md index 0ed3a64e1..7a6a1b552 100644 --- a/evaluations/plutonication_1_keeganquigley.md +++ b/evaluations/plutonication_1_keeganquigley.md @@ -1,25 +1,85 @@ # Evaluation -- **Status:** In progress +- **Status:** Accepted - **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/Plutonication.md - **Milestone:** 1 - **Previously successfully merged evaluation:** All by keeganquigley | Number | Deliverable | Accepted | Link | Notes | | ------------- | ------------- | ------------- | ------------- | ------------- | -| **0a.** | License | | [PlutonicationServer](https://github.com/RostislavLitovkin/PlutonicationServer/blob/main/LICENSE) | MIT | -| **0b.** | Documentation | | Docs for running all codes is in the [Readme](https://github.com/RostislavLitovkin/PlutonicationServer/#readme). [Guide for deploying to Cloud](https://plutonication-acnha.ondigitalocean.app/deploy) is here. I have also included [Low-level docs](https://plutonication-acnha.ondigitalocean.app/docs) for tinkerers. | | -| **0c.** | Testing and Testing Guide | | Guide for running tests is in the [Readme](https://github.com/RostislavLitovkin/PlutonicationServer/#readme) | | -| **0d.** | Docker | | [Dockerfile](https://github.com/RostislavLitovkin/PlutonicationServer/blob/milestone-delivery/Dockerfile) | | -| 1a. | create_room | | [create_room](https://github.com/RostislavLitovkin/PlutonicationServer/blob/c848a88cf5f28d47542f1be0d7cc2bdee927558f/plutonication/events.py#L39) | | -| 1b. | pubkey | | [pubkey](https://github.com/RostislavLitovkin/PlutonicationServer/blob/c848a88cf5f28d47542f1be0d7cc2bdee927558f/plutonication/events.py#L51) | | -| 1c. | sign_payload | | [sign_payload](https://github.com/RostislavLitovkin/PlutonicationServer/blob/c848a88cf5f28d47542f1be0d7cc2bdee927558f/plutonication/events.py#L65) | | -| 1d. | sign_raw | | [sign_raw](https://github.com/RostislavLitovkin/PlutonicationServer/blob/c848a88cf5f28d47542f1be0d7cc2bdee927558f/plutonication/events.py#L77) | | -| 1e. | payload_signature | | [payload_signature](https://github.com/RostislavLitovkin/PlutonicationServer/blob/c848a88cf5f28d47542f1be0d7cc2bdee927558f/plutonication/events.py#L89) | | -| 1f. | raw_signature | | [raw_signature](https://github.com/RostislavLitovkin/PlutonicationServer/blob/c848a88cf5f28d47542f1be0d7cc2bdee927558f/plutonication/events.py#L109C1-L109C1) | | +| **0a.** | License | | [PlutonicationServer](https://github.com/RostislavLitovkin/PlutonicationServer/blob/main/LICENSE) | MIT | +| **0b.** | Documentation | | Docs for running all codes is in the [Readme](https://github.com/RostislavLitovkin/PlutonicationServer/#readme). [Guide for deploying to Cloud](https://plutonication-acnha.ondigitalocean.app/deploy) is here. I have also included [Low-level docs](https://plutonication-acnha.ondigitalocean.app/docs) for tinkerers. | Ok. | +| **0c.** | Testing and Testing Guide | | Guide for running tests is in the [Readme](https://github.com/RostislavLitovkin/PlutonicationServer/#readme) | Ok. | +| **0d.** | Docker | | [Dockerfile](https://github.com/RostislavLitovkin/PlutonicationServer/blob/milestone-delivery/Dockerfile) | Ok. | +| 1a. | create_room | | [create_room](https://github.com/RostislavLitovkin/PlutonicationServer/blob/c848a88cf5f28d47542f1be0d7cc2bdee927558f/plutonication/events.py#L39) | Ok. | +| 1b. | pubkey | | [pubkey](https://github.com/RostislavLitovkin/PlutonicationServer/blob/c848a88cf5f28d47542f1be0d7cc2bdee927558f/plutonication/events.py#L51) | Ok. | +| 1c. | sign_payload | | [sign_payload](https://github.com/RostislavLitovkin/PlutonicationServer/blob/c848a88cf5f28d47542f1be0d7cc2bdee927558f/plutonication/events.py#L65) | Ok. | +| 1d. | sign_raw | | [sign_raw](https://github.com/RostislavLitovkin/PlutonicationServer/blob/c848a88cf5f28d47542f1be0d7cc2bdee927558f/plutonication/events.py#L77) | Ok. | +| 1e. | payload_signature | | [payload_signature](https://github.com/RostislavLitovkin/PlutonicationServer/blob/c848a88cf5f28d47542f1be0d7cc2bdee927558f/plutonication/events.py#L89) | Ok. | +| 1f. | raw_signature | | [raw_signature](https://github.com/RostislavLitovkin/PlutonicationServer/blob/c848a88cf5f28d47542f1be0d7cc2bdee927558f/plutonication/events.py#L109C1-L109C1) | Ok. | # General Notes +Overall, great documentation and everything works as expected. Looking forward to seeing the next milestone where everything should come together. + +## Evaluation v2 + +Issues have been resolved, all unit and e2e tests pass now: + +```js +npx playwright test + +Running 8 tests using 1 worker +[chromium] › events.spec.js:77:7 › events › create_room and pubkey +dApp connected +Wallet connected +[chromium] › stresstest.spec.js:6:7 › stress tests › limit_socketio +Connected +pong: 0 +pong: 1 +pong: 2 +pong: 3 +pong: 4 +pong: 5 +pong: 6 +pong: 7 +pong: 8 +pong: 9 +pong: 10 +pong: 11 +pong: 12 +pong: 13 +pong: 14 +pong: 15 +pong: 16 +pong: 17 +pong: 18 +pong: 19 +pong: 20 +pong: 21 +pong: 22 +pong: 23 +pong: 24 +pong: 25 +pong: 26 +pong: 27 +pong: 28 + 8 passed (8.0s) +``` +Events tests pass: + +```js + npx playwright test events.spec.js + +Running 7 tests using 1 worker +[chromium] › events.spec.js:77:7 › events › create_room and pubkey +dApp connected +Wallet connected + 7 passed (7.4s) +``` + +## Evaluation v1 + Docker builds successfully: ```sh