Incosistent provider score

[lobis]

Sometimes the provider score is not what it should be, I think because the providers are not being registered correctly. (I am using kusama.w3f.community as the source of truth, if this is not the case please point me towards a more accurate source for scoring).

For example, I have two validators under the 1KV programme and they both share location and provider and they are both in the 1.9.0 version (latest at the time of writing).

• https://kusama.w3f.community/candidate/E1iq5eqQqTz8dM1P1bqDEd5TtS2DK2cHLapcsMqh6CnRJkV. Here the provider score is 98.94736842105263 which I believe to be correct. More importantly, in this case the provider information is also shown.
• https://kusama.w3f.community/candidate/GvG8TntkK5Lsg7DCA86MKYNGyYnxktNk4cS1x115eiQfRpT. In this case the provider score is 25 points (remember both validators use the same provider). In this case the provider information is missing.

In summary one of my validators is getting less points than it should due to missing provider information. I have reported this in the past via email but I decided to open an issue to better keep track of progress.

Thanks!

[lobis]

Also see #2807.

[ironoa]

Hey lobis,
just double checked and I noticed that:

• the two validators have a similar provider score
• the two validators have a different provider

[lobis]

Hey lobis, just double checked and I noticed that:

• the two validators have a similar provider score
• the two validators have a different provider

Yes, since I wasn't getting the correct provider score I deployed the validator in the aws cloud for a few hours, then redeployed to the original location. The provider score updated to the aws location but never updated back to what it should've been in the first place (the same one as my other validator). Atleast now I am getting the points I should be getting so I can't complain about that.

However this second validator (the one with the provider issue) seems to still be having problems with the scoring backend, since it's been a long time since it gets any nomination and it's now averaging around 800 points. It was recently nominated but lost the nomination after 2 eras, all while maintaining a very high score. For instance my other validator has lower score and is consistently nominated for more time, so i would love to know what is going on (I guess this last part would be more relevant in #2807).

[lobis]

Hey lobis, just double checked and I noticed that:

• the two validators have a similar provider score
• the two validators have a different provider

It appears it's broken again, I don't have a provider anymore.

[lobis]

After trying different things out, my conclusion is that the issue only arises when multiple validators share the same ip. In my case I was self-hosting both validators in my home network. I assume this it not intended so it's a bug.

@ironoa I'll close the issue if you say this is intended behaviour. I'll look into migrating at least one of my validators into the cloud so I can get proper scoring.

[ironoa]

you are right @lobis thanks for investigating, this PR addresses the multiple validators share the same ip bug. It will be soon deployed (currently under testing on staging)

[lobis]

Thanks! Everything seems fine from my end.