From 44b3f670e97a0ce1d3a99e35f5ea193f08cbf4f1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Bostr=C3=B6m?= Date: Thu, 19 Sep 2024 15:59:40 +0200 Subject: [PATCH 1/4] Fix timestamp definition to align with webrtc-stats --- webrtc.html | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/webrtc.html b/webrtc.html index 5cbb671f6..ba9592fb8 100644 --- a/webrtc.html +++ b/webrtc.html @@ -15794,9 +15794,10 @@

- The {{timestamp}}, of type {{DOMHighResTimeStamp}}, - associated with this object. The time is relative to the UNIX - epoch (Jan 1, 1970, UTC). For statistics that came from a + Timestamps are expressed with {{DOMHighResTimeStamp}} + [[HIGHRES-TIME]], and are defined as + {{Performance.timeOrigin}} + {{Performance.now()}} at the time + the information is collected. For statistics that came from a remote source (e.g., from received RTCP packets), {{timestamp}} represents the time at which the information arrived at the local endpoint. The remote timestamp can be From 29e027f0d45ab9e5e8309196ea52ba5da3a5df1e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Bostr=C3=B6m?= Date: Tue, 24 Sep 2024 20:43:11 +0200 Subject: [PATCH 2/4] Add amendments --- amendments.json | 13 +++++++++++++ base-rec.html | 2 +- webrtc.html | 2 +- 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/amendments.json b/amendments.json index 2348a5cc4..098c1424c 100644 --- a/amendments.json +++ b/amendments.json @@ -1001,5 +1001,18 @@ "web-platform-tests/wpt#47663" ] } + ], + "stats-timestamp": [ + { + "description": "Use Performance.timeOrigin + Performance.now() for stats timestamps", + "type": "correction", + "status": "candidate", + "difftype": "modify", + "id": 50, + "pr": 3005, + "tests": [ + "webrtc/TODO.html" + ] + } ] } diff --git a/base-rec.html b/base-rec.html index b06488e6a..9513c2370 100644 --- a/base-rec.html +++ b/base-rec.html @@ -15215,7 +15215,7 @@

timestamp of type DOMHighResTimeStamp
-
+

The timestamp, of type DOMHighResTimeStamp, associated with this object. The time is relative to the UNIX diff --git a/webrtc.html b/webrtc.html index ba9592fb8..230a8d9fd 100644 --- a/webrtc.html +++ b/webrtc.html @@ -10729,7 +10729,7 @@

timestamp of type {{DOMHighResTimeStamp}}, required -
+

The {{timestamp}} indicating the most recent time a frame from an RTP packet, originating from this source, was From 0602bbfdaa0e4342d8ef16015af079f07ac0eaa2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Bostr=C3=B6m?= Date: Tue, 24 Sep 2024 21:11:12 +0200 Subject: [PATCH 3/4] ... --- amendments.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/amendments.json b/amendments.json index 098c1424c..ba510ba5e 100644 --- a/amendments.json +++ b/amendments.json @@ -1011,7 +1011,7 @@ "id": 50, "pr": 3005, "tests": [ - "webrtc/TODO.html" + "webrtc/RTCPeerConnection-getStats-timestamp.https.html" ] } ] From 09f394bd85fb91c1c85f5aca18635be3bedf27e1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Bostr=C3=B6m?= Date: Mon, 30 Sep 2024 16:23:04 +0200 Subject: [PATCH 4/4] Add testUpdates --- amendments.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/amendments.json b/amendments.json index 8604029ad..ee96390f6 100644 --- a/amendments.json +++ b/amendments.json @@ -1091,6 +1091,9 @@ "pr": 3005, "tests": [ "webrtc/RTCPeerConnection-getStats-timestamp.https.html" + ], + "testUpdates": [ + "web-platform-tests/wpt#48361" ] } ]