-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check variable naming inside of getAttributeType and getPropertyType methods #496
Comments
So IIUC, the problem is the confusion with Element.tagName) which returns uppercased qualified name. So the suggestion is to rename the |
cc @smaug---- So another source of confusion is the "attribute" argument from Comparing with [createAttribute(https://dom.spec.whatwg.org/#dom-document-createattribute)] and createAttributeNS, it could better be renamed "local name" or "qualified name". Besides lowercasing (see #424 for a proposal to remove that), the argument is pass as is to Get Trusted Type data for attribute which treats it as a "local name", so it seems what this attribute really is. |
See w3c/trusted-types#496 (comment) Differential Revision: https://phabricator.services.mozilla.com/D226476 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1917783 gecko-commit: aba2bd9d817f21ac8a590235dc6635861aea19eb gecko-reviewers: smaug
…ibute name. r=smaug See w3c/trusted-types#496 (comment) Differential Revision: https://phabricator.services.mozilla.com/D226476
See w3c/trusted-types#496 (comment) Differential Revision: https://phabricator.services.mozilla.com/D226476 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1917783 gecko-commit: aba2bd9d817f21ac8a590235dc6635861aea19eb gecko-reviewers: smaug
See w3c/trusted-types#496 (comment) Differential Revision: https://phabricator.services.mozilla.com/D226476 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1917783 gecko-commit: aba2bd9d817f21ac8a590235dc6635861aea19eb gecko-reviewers: smaug
…ibute name. r=smaug See w3c/trusted-types#496 (comment) Differential Revision: https://phabricator.services.mozilla.com/D226476
See WebKit/WebKit#26552 (comment) for context but TLDR make sure these two functions have parameters and variables named coherently.
The text was updated successfully, but these errors were encountered: