Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require a gesture? #210

Open
marcoscaceres opened this issue Oct 7, 2022 · 3 comments · May be fixed by #218
Open

Require a gesture? #210

marcoscaceres opened this issue Oct 7, 2022 · 3 comments · May be fixed by #218

Comments

@marcoscaceres
Copy link
Member

I wonder if we should require transient activation to perform a rotation?

Going fullscreen would give us the initial rotation... but it would be better to request the rotation when going full screen in the first place.

Then, one could change rotation based on a click() or some other gesture.

@michaelwasserman
Copy link
Member

That's a reasonable line of inquiry, presumably to protect users against abusive sites.

Would you suggest consuming or simply gating on a transient activation signal?

IIUC, sites can currently request an orientation lock change while fullscreen, and invoke another transient activation gated (or consuming) API in response to the same user gesture. How might we determine whether introducing this new requirement would break existing usage and use cases?

@marcoscaceres
Copy link
Member Author

I think we want to consume it...

How might we determine whether introducing this new requirement would break existing usage and use cases?

We might need to have a look (via telemetry)... or one of us takes the compat hit.

@michaelwasserman
Copy link
Member

See my comment on #218. Passive telemetry gauging the impact of simply requiring transient user activation (i.e. measure orientation locks that would fail) is far more tractable than that of consuming it (i.e. also measuring other API usage failures after orientation lock consumes). Gating on the activation timestamp alone could help prevent abuse, but consuming may be a better long-term goal. Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants