Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aggregation tests which involve unbound variables #39

Open
lisp opened this issue Feb 1, 2016 · 6 comments
Open

add aggregation tests which involve unbound variables #39

lisp opened this issue Feb 1, 2016 · 6 comments
Labels

Comments

@lisp
Copy link

lisp commented Feb 1, 2016

two tests have been proposed to demonstrate permitted aggregation results in the presence of unbound variables.

it would be worthwhile, in addition, to include tests which distinguish results where an implementation suppresses unbound values where permitted.

  • one test which fails if the respective sample result is unbound. this should be associated with a new feature, to document which of the alternative behaviours an implementation follows.
  • one test which requires that an unbound value be valid as a group key. i did not see this yet covered, but may have overlooked a test which already does.
@gkellogg
Copy link
Member

gkellogg commented Feb 1, 2016

It's probably useful to surface this on [email protected] and [email protected], as not everyone interested in this subscribes to the GitHub issues feed.

@gkellogg
Copy link
Member

gkellogg commented Feb 1, 2016

@gkellogg
Copy link
Member

gkellogg commented Feb 1, 2016

A PR with proposed tests and results would be welcome.

@lisp
Copy link
Author

lisp commented Feb 1, 2016

yes, this is a follow-on to that post.

before proposing tests, it would be good to have some degree of consensus concerning the content:

  • whould it be appropriate to a feature?
  • if so, what it might be named? would it be 'mf' or 'sd'?
  • should it be reflected in the service description?

@joernhees
Copy link
Contributor

just linking this more directly: kasei@389617a @kasei

@gkellogg
Copy link
Member

@lisp, perhaps a conversation referencing this thread, on [email protected] and [email protected] might spur more discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants