-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should PiP video removed from the DOM leave PiP? #99
Comments
It would be great if spec could document the intended behavior for this. @jernoble @mounirlamouri Let me know what you think and I'll update the spec. |
Given that you can send a video not in the document in PIP, I see no reason why leaving the document should exit Picture-in-Picture. I don't have a strong opinion because it's probably an edge case anyway. Is there a specific reason why Safari did this? |
We're debating this internally. We think it was just a side effect of our original conflation of "fullscreen presentation modes" and "picture-in-picture", and not intended as an explicit policy. WebKit has always supported entering video fullscreen from a non-DOM |
@beaufortfrancois should we close? |
Sure. Let's close. |
It looks like Safari updated their behaviour:
Source: https://trac.webkit.org/changeset/265904/webkit/ @mounirlamouri Shall we update Chrome and not pause as well for consistency? |
The issue with not pausing is that it goes against the HTML specification requirements (see just above https://html.spec.whatwg.org/multipage/media.html#seeking). That means the WebKit change is against spec. I would rather not have the Picture-in-Picture specification changes the behaviour of the HTML specification. We could obviously ask for the HTML specification to update this section if we believe it's worth it. |
@jernoble (gentle ping) |
@pliu6 (gentle ping) |
Raised an issue against HTML: whatwg/html#6271 |
This CL makes sure video do not pause when playing in Picture-in-Picture and subsequently removed from the Document. Spec: w3c/picture-in-picture#99 Change-Id: Ifefd961803cc47c64d394aa52454313cbcef603a Bug: TODO
This CL makes sure video do not pause when playing in Picture-in-Picture and subsequently removed from the Document. Spec: w3c/picture-in-picture#99 Change-Id: Ifefd961803cc47c64d394aa52454313cbcef603a Bug: TODO
This CL makes sure video do not pause when playing in Picture-in-Picture and subsequently removed from the Document. Spec: w3c/picture-in-picture#99 Change-Id: Ifefd961803cc47c64d394aa52454313cbcef603a Bug: TODO
This CL makes sure video do not pause when playing in Picture-in-Picture and subsequently removed from the Document. Spec: w3c/picture-in-picture#99 Change-Id: Ifefd961803cc47c64d394aa52454313cbcef603a Bug: TODO
This CL makes sure video do not pause when playing in Picture-in-Picture and subsequently removed from the Document. Spec: w3c/picture-in-picture#99 Change-Id: Ifefd961803cc47c64d394aa52454313cbcef603a Bug: TODO
This CL makes sure video do not pause when playing in Picture-in-Picture and subsequently removed from the Document. Spec: w3c/picture-in-picture#99 Change-Id: Ifefd961803cc47c64d394aa52454313cbcef603a Bug: 1167643
This CL makes sure video do not pause when playing in Picture-in-Picture and subsequently removed from the Document. Spec: w3c/picture-in-picture#99 Change-Id: Ifefd961803cc47c64d394aa52454313cbcef603a Bug: 1167643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627311 Commit-Queue: François Beaufort <[email protected]> Reviewed-by: Mounir Lamouri <[email protected]> Cr-Commit-Position: refs/heads/master@{#845100}
This CL makes sure video do not pause when playing in Picture-in-Picture and subsequently removed from the Document. Spec: w3c/picture-in-picture#99 Change-Id: Ifefd961803cc47c64d394aa52454313cbcef603a Bug: 1167643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627311 Commit-Queue: François Beaufort <[email protected]> Reviewed-by: Mounir Lamouri <[email protected]> Cr-Commit-Position: refs/heads/master@{#845100}
I've just updated Chromium to make sure video do not pause when playing in Picture-in-Picture and subsequently removed from the Document. See CL at https://chromium-review.googlesource.com/c/chromium/src/+/2627311 I've also added some web platform tests at web-platform-tests/wpt#27185 and make sure both Chrome and Safari browsers pass them. |
…deo when removed from document, a=testonly Automatic update from web-platform-tests [Picture-in-Picture] Do not pause PiP video when removed from document This CL makes sure video do not pause when playing in Picture-in-Picture and subsequently removed from the Document. Spec: w3c/picture-in-picture#99 Change-Id: Ifefd961803cc47c64d394aa52454313cbcef603a Bug: 1167643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627311 Commit-Queue: François Beaufort <[email protected]> Reviewed-by: Mounir Lamouri <[email protected]> Cr-Commit-Position: refs/heads/master@{#845100} -- wpt-commits: c021b6e74824432009f921266ecb34c4585911e2 wpt-pr: 27185
…deo when removed from document, a=testonly Automatic update from web-platform-tests [Picture-in-Picture] Do not pause PiP video when removed from document This CL makes sure video do not pause when playing in Picture-in-Picture and subsequently removed from the Document. Spec: w3c/picture-in-picture#99 Change-Id: Ifefd961803cc47c64d394aa52454313cbcef603a Bug: 1167643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627311 Commit-Queue: François Beaufort <beaufort.francoisgmail.com> Reviewed-by: Mounir Lamouri <mlamourichromium.org> Cr-Commit-Position: refs/heads/master{#845100} -- wpt-commits: c021b6e74824432009f921266ecb34c4585911e2 wpt-pr: 27185 UltraBlame original commit: 932af8508133dffede9337c6c8193c0cff03eb4c
…deo when removed from document, a=testonly Automatic update from web-platform-tests [Picture-in-Picture] Do not pause PiP video when removed from document This CL makes sure video do not pause when playing in Picture-in-Picture and subsequently removed from the Document. Spec: w3c/picture-in-picture#99 Change-Id: Ifefd961803cc47c64d394aa52454313cbcef603a Bug: 1167643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627311 Commit-Queue: François Beaufort <[email protected]> Reviewed-by: Mounir Lamouri <[email protected]> Cr-Commit-Position: refs/heads/master@{#845100} -- wpt-commits: c021b6e74824432009f921266ecb34c4585911e2 wpt-pr: 27185
Removing agenda label as it sounds that this is reaching a conclusion. |
This CL makes sure video do not pause when playing in Picture-in-Picture and subsequently removed from the Document. Spec: w3c/picture-in-picture#99 Change-Id: Ifefd961803cc47c64d394aa52454313cbcef603a Bug: 1167643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627311 Commit-Queue: François Beaufort <[email protected]> Reviewed-by: Mounir Lamouri <[email protected]> Cr-Commit-Position: refs/heads/master@{#845100} GitOrigin-RevId: 38117682e81b25f0307256541f6a9bb4fda887ac
In Chrome and Safari, a video element not attached to the DOM can start playing and enter Picture-in-Picture. When video is attached to the DOM while playing in Picture-in-Picture, browser implementations differ though when video is removed from the DOM:
It looks like Safari takes a hint from the Fullscreen API:
Note that the Fullscreen API doesn't allow an element not atttached to the DOM to enter fullscreen unlike Picture-in-Picture that does not prevent it.
The text was updated successfully, but these errors were encountered: