Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify and consolidate img ARIA allowances #453

Merged
merged 15 commits into from
Oct 3, 2023

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Mar 16, 2023

This PR closes #424 and #452

This update serves to both clarify that an image with a name, regardless of how that name is provided, should allow the specified roles.

Additionally, it consolidates the expectations for an image with an empty alt, or a missing alt so long as they also have no accessible name.

Using the implicit role of the image, for all instances, has already been marked as not recommended, so errors should not be exposed for that, but rather warnings, if the conformance checker exposes non-error messages.

Test cases for the passing examples


Preview | Diff

This PR closes #424 and #452

Description of changes to come....
@scottaohara scottaohara added Allowed roles Pertaining to the allowed roles of HTML elements needs implementation commitment Cannot merge into spec until implementations in conformance checkers has been confirmed. needs changelog entry once 2 implementations land, we can merge and note it in our changelog. labels Mar 16, 2023
@scottaohara scottaohara added Meets 2 implementations req Indicates that a spec change has met the necessary 2 implementations needed to merge. and removed needs implementation commitment Cannot merge into spec until implementations in conformance checkers has been confirmed. labels Jun 16, 2023
@scottaohara scottaohara removed the needs changelog entry once 2 implementations land, we can merge and note it in our changelog. label Oct 3, 2023
@scottaohara scottaohara merged commit 5cae232 into gh-pages Oct 3, 2023
2 checks passed
@scottaohara scottaohara deleted the img-allowances-update branch October 3, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Allowed roles Pertaining to the allowed roles of HTML elements Meets 2 implementations req Indicates that a spec change has met the necessary 2 implementations needed to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider clarifying / simplifying image rules
1 participant