-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-aam PR 230] Update aria-labelledby AXAPI mapping to use AXTitle #2199
base: main
Are you sure you want to change the base?
Conversation
Include co-author when merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Rahim, this PRs has been moved, so please continue the work here :)
I have a few questions/comments for you:
- This looks good, but from the issue, it looks like
aria-label
is updated toAXTitle
as well, where you doing that in a separate PR? Seems to me like it could be done here as well. - Can you confirm whether there will need to be a change in firefox and chrome? Seems like it! if so we need to track those implementations.
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello @spectranaut!
Agreed (thank you), I've updated the PR to include both
No change is required for implementations, so related API tests should be crafted to allow either attribute. Although |
Copies w3c/core-aam#230 by @rahimabdi
Closes w3c/core-aam#215