-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add styles and index support for experimental content #2836
Comments
@daniel-montalvo, mentioning you and @shawna-slh for review of the above spec. Please review both design objectives and implementation details. Here is a little more context that may help as you review it. Note: I'm targeting having this capability ready before end of year so we can start work on an example of tree, listbox, or tabs that uses the new aria-actions feature. Moving aria-actions forward is a 2024 priority for ARIA. In this spec, experimental means content that the ARIA WG needs in APG as a prerequisite for finalizing an ARIA feature so it can be merged into the editor's draft of the ARIA spec. The APG example of a new ARIA feature provides a live example, as opposed to a WPT test, that stakeholders can use to observe how browser implementations, which may be behind a flag, are working. The experimental example implementation also enables the ARIA-AT CG to draft tests of proposed AT behaviors to ensure that AT developers have the same understanding of what is expected from AT for the new feature. The purpose and nature of the experimental content would be explained in the "Read This First" disclosure, that would be expanded by default on these pages. In normal example pages, e.g., accordion example read this first, the read this first is collapsed by default. |
also tagging ARIA Chairs, @jnurthen @spectranaut |
@mcking65 this is a great idea and is similar to how other doc sites such as MDN show experimental features, although this implementation design seems a little more thorough. I have a question regarding the proposal.
While I understand the need not to be lax with presenting this information so that only those who really want it, find it; will hiding it from search results prevent those users who want to experiment with the feature from finding the information? I know on MDN experimental features are included in search results but labelled as experimental on index/reference pages. |
Hi @mcking65, first of all this seems like a great idea - I never thought of this before but it makes sense. I was wondering if you have any experimental content authored yet. If not I think I would advocate to hold off implementing this feature until at least one piece of content is ready. If we develop the feature using placeholder content I'm concerned the work would either get stuck in a branch or need to be overhauled once the real content is ready. I also wanted to weigh in on the search indexing question. The good news is that we recently figured out how to control the search indexes on the WAI website, but the bad news is that this needs to be controlled at the level of the WAI website and can't be directly configured from the wai-aria-practices repo. In effect we would need to make PRs against the wai-website repo for every new piece of experimental content. For this reason I find myself hoping that including the content in the search is a viable solution, assuming the fact that it's experimental is clearly communicated. |
@alflennik asked:
None is ready yet. I am going to pursue getting an example for aria-actions in the works. I am thinking about using a copy of one of the file tree examples as starting content for that.
I don't understand this concern. We should be able to use any existing example as a placeholder, and the design should work. The visual design of the experimental example page should not have any dependency on the content of a specific example. An experimental example page will have exactly the same content sections and format as a consensus example page. To transform an experimental example to a consensus example, the only content changes would be:
I don't know why it would have to be a new WAI web site PR for each new experimental page if the search code was simply looking for the `data-content-phase="experimental" attribute on main. Nevertheless, if there are no concerns from WAI staff, I can get behind not excluding the pages from WAI site search. I've revised the specification to remove this requirement. Probably more people would discover the content via google anyway. I think the design and content will be sufficiently clear about the status of the content as experimental. |
HI @mcking65 , the functionality for this is ready we are just waiting on the content, do you have it? |
No, we do not yet have content. That will be addressed with #3015. |
…l' (pull #2977) Provides the infrastructure to treat example pages marked as experimental differently from other example pages as defined in issue #2836: 1. A different "Read This First" section that is expanded by default is inserted into experimental example pages. 2. Experimental example pages are excluded from the main index tables and listed in a separate section at the bottom of the index page. Experimental example pages are identified by a data attribute on the main element as defined in issue #2836. --------- Co-authored-by: Stalgia Grigg <[email protected]> Co-authored-by: Matt King <[email protected]>
Added documentation of the feature to the editorial guidelines. This issue is now complete. |
Develop support for example pages that include a draft ARIA feature that is still a work in progress. These pages will enable the accessibility community to develop support for the experimental feature but will clearly indicate their content is intended to be used only for that purpose.
Design Objectives
Overview of Implementation proposal
There are two types of changes included in this implementation: editorial and infrastructure. Editors are responsible for ensuring the editorial changes are made to any example page that includes experimental content. The infrastructure changes will be baked into the build process.
Together, the infra and editorial changes will satisfy the design objectives by:
Editorial changes
data-content-phase="experimental"
to the main element.Infrastructure changes
experimental-example-usage-warning.html
that is similar to content/shared/templates/example-usage-warning.html. In Include theopen
attribute on thedetails
element.experimental-example-usage-warning.html
content instead ofexample-usage-warning.html
on pages that havedata-content-phase="experimental
.data-content-phase="experimental"
from the index tables that list examples by role, state, and property.The text was updated successfully, but these errors were encountered: