update endpoint from Prove to create #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkhraisha
changed the title
PatStLouis
approved these changes
Mar 26, 2024
msporny
reviewed
Apr 2, 2024
msporny
reviewed
Apr 2, 2024
msporny
reviewed
Apr 2, 2024
msporny
requested changes
Apr 2, 2024
There was a problem hiding this comment.
The group decided to use the controller pattern from the REST API Design Guidelines a while ago (which means the API should be /presentations/create):
https://github.com/w3c-ccg/vc-api/?tab=readme-ov-file#style-versioning-and-contribution
|
I believe on the call we resolved to not use 'presentations/create' is there anything else I should hange in this PR? |
dlongley
approved these changes
Apr 16, 2024
The group discussed this on 2024-04-16 and agreed that it is good to go as-is. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all references from proving a presentations to become creating a presentations.
Changes endpoint from POST
presentations/proveto POSTpresentationsPreview | Diff