Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine how to test for data integrity proofs when VC might contain multiple proofs conforming to another spec #8

Closed
4 tasks
aljones15 opened this issue May 21, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@aljones15
Copy link
Contributor

aljones15 commented May 21, 2022

Verifiable Credentials can contain multiple proofs signed by different issuers and signature suites.

In the case of this library I think we should focus on this:

  • Pass in a type that we testing for such as Ed25519Signature2020.
  • Filter the VC's proofs so that we are only testing on proofs with the expected type
  • If the filtered proofs array has a length 0 or less then fail all assertions
  • Otherwise we test every proof in the filtered Array for data integrity
@aljones15 aljones15 self-assigned this May 21, 2022
@aljones15 aljones15 added the enhancement New feature or request label May 21, 2022
@aljones15 aljones15 changed the title Determine how to test for properties data integrity when VC might contain multiple proofs conforming to another spec Determine how to test for data integrity proofs when VC might contain multiple proofs conforming to another spec Oct 16, 2024
@aljones15
Copy link
Contributor Author

solution to this is assert on any proof with type DataIntegrityProof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant