-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(styles): revisit sass restriction remediation #13938
Conversation
|
I knew. Hence, this commit is aiming to overcome the unsuccessful & cyclical approach that had been taken. I hope this helps you and the team to decide go/nogo with this commit: The former, we needed to "centralize" the declaration of '@use "sass:math"'. Nevertheless, release 2.5.2 has redundant declarations, which had been done due to try to fulfill coverage in an inappropriate way. If you mean, in the latter, that you were struggling with unwanted stoppages reported, this commit may give its countermeasure wholly or partially, including "centralization". In practical, the '@use' directive can only be declared once i.e. in the topmost '_variables.scss' file (or another). Then the 'div()' method is enabled its use in low-level stylesheet implementations as if it were global. These are what I have tried since previous. Hope this helps. |
19a504a
to
b6ca8e9
Compare
This clearly is not the case, if you look at the first test deployment there are raw This PR doesn't even build anymore after b6ca8e9, if you do have another solution to this please test it locally first by running |
Description
Revisit remediation of PR #13704
Fixes #13694
Fixes Tokyo-Metro-Gov/covid19#6346
Motivation and Context
Since it is figured out that the problem was caused by insufficiency fo fixing errors,
SASS
compilation error took place on the previousSASS-mathdiv
facility in the PR shown above.It is inevitable for us to fix this soon to let rhe new SASS restrictions / lintings come in .
How Has This Been Tested?
Check, build & run to see at least no similar error to previus is produced when monitoring the behavior, and the application wchich uses
Vuetify
can work as welll as before the program fix.Also checked the build log that no SASS-related errors were produced:
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).