Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump deps #238

Merged
merged 3 commits into from
Aug 20, 2024
Merged

chore: bump deps #238

merged 3 commits into from
Aug 20, 2024

Conversation

Mister-Hope
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Aug 20, 2024

Pull Request Test Coverage Report for Build 10474580301

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.488%

Totals Coverage Status
Change from base Build 10474499139: 0.0%
Covered Lines: 1091
Relevant Lines: 1706

💛 - Coveralls

@Mister-Hope
Copy link
Member Author

Mister-Hope commented Aug 20, 2024

Also need some help here, I try to switch to modern api in Vite, but our usage about using file:/// in @forward fails in Vite.

From the original PR https://github.com/vitejs/vite/pull/17754/files, it seems that a same importer with legacy is correctly applied to modern api, so I am not sure how this issue happens.

Our final goal is to make webpack and vite both running on modern-compiler with sass-embedded by default, but we are meeting problems since #231

@meteorlxy The whole ecosystem is blocking by this and we already meet issues downstream.

(With sass-loader@v16, modern api is already the default and users may switch to sass-embedded by referencing it in their projects)

@Mister-Hope
Copy link
Member Author

I will try to split this one with:

  1. deps bump and forcing to use the legacy one
  2. a new pr using sass-embedded and modern-api by default.

The first one should be easy, and we will focus on the second one.

@Mister-Hope Mister-Hope merged commit 5269931 into main Aug 20, 2024
31 checks passed
@Mister-Hope Mister-Hope deleted the vp15 branch August 20, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants