Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make sass optional and support sass-embedded #231

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

Mister-Hope
Copy link
Member

@Mister-Hope Mister-Hope commented Jul 28, 2024

sass-loader v16 prefer sass-embedded with modern api, and vite 5.4 supports modern api as well.

So we want to use sass-embedded with modern-compiler to improve sass performance.

pengzhanbo
pengzhanbo previously approved these changes Jul 28, 2024
@Mister-Hope
Copy link
Member Author

Webpack ci are all falling, could you help to investigate?

@pengzhanbo
Copy link
Member

pengzhanbo commented Jul 28, 2024

Webpack ci are all falling, could you help to investigate?

I investigated the issue for a while and can only confirm that the problem is caused by plugin-pwa, as the vuepress build completes but the process does not terminate.

I suspect that the issue lies with this line of code pwaPlugin.ts#L71, as commenting it out allows the process to successfully terminate upon repeated execution. However, when building the project without the directories e2e/.vuepress/{.cache,.temp,dist}, the process does not terminate.

This confuses me; I am not clear about what happened to cause it.

It is important to note that when I switched back to the main branch and executed e2e:build-webpack, it worked fine, so it is very likely that the issues are due to dependency upgrades in this branch.

@Mister-Hope
Copy link
Member Author

@meteorlxy any ideas?

@Mister-Hope Mister-Hope merged commit cce614b into main Sep 10, 2024
32 checks passed
@Mister-Hope Mister-Hope deleted the sass branch September 10, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants