Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that vue-router does not handle head/metadata like page title #1539

Open
Soviut opened this issue Aug 30, 2022 · 5 comments
Open

Document that vue-router does not handle head/metadata like page title #1539

Soviut opened this issue Aug 30, 2022 · 5 comments
Labels
docs Concerns the documentation content or the documentation website

Comments

@Soviut
Copy link
Contributor

Soviut commented Aug 30, 2022

What problem does this feature solve?

A colleague who is new to Vue expected that vue-router would be able to update the page title; this makes some sense. Vue-router introduces the concept of pages, so there could be an expectation that it also has facilities for updating the page metadata.

It would be good to document that vue-router does not have these facilities, but also link to something like @vueuse/head that can.

What does the proposed API look like?

A new page in the documentation guides that explains that vue-router does not handle metadata, but gives examples and links to some populate head/metadata libraries like @vueuse/head.

@posva
Copy link
Member

posva commented Aug 30, 2022

This topic is useful but we don't really have a place for it. Do you have a suggestion? A PR here would be more helpful.

Note that documentation should point the user how to do things, not tell the user what isn't possible

@Soviut
Copy link
Contributor Author

Soviut commented Aug 30, 2022

@posva I was planning to do a PR sometime this week. This is just here as a reminder.

I figured a "page head and title" page under the Advanced topics in the guides might be a good place.

image

@posva
Copy link
Member

posva commented Aug 30, 2022

A whole new page for it looks like too much unless there is that much to say. Right now, this could be just mentioned in the afterEach hooks section

@posva posva added the docs Concerns the documentation content or the documentation website label Aug 30, 2022
@Soviut
Copy link
Contributor Author

Soviut commented Aug 30, 2022

I was planning on including links and examples to a few libraries that can update the head/metadata/title.

@sourabh504
Copy link
Contributor

@posva and @Soviut Below are the details that can be added in document

The router instance has a afterEach hook that gets called after route change. This can be used to set window title as detailed below:

// Let's say this is your router instance, with all "Named Routes"
const ROUTER_INSTANCE = new VueRouter({
mode: "history",
routes: [
{ path: "/", name: "HomeComponentName", component: HomeComponent },
{ path: "/about", name: "AboutComponentName", component: AboutComponent },
{ path: "*", name: "RouteErrorName", component: RouteError }
]
})

// Assign page titles for each of the "named routes"
// Reason: This allows us to have short named routes, with descriptive title
const PAGE_TITLE = {
"HomeComponentName": "Your Dashboard",
"AboutComponentName": "About Us Page",
"RouteErrorName": "Error: Page not found"
}

ROUTER_INSTANCE.afterEach((toRoute, fromRoute) => {
window.document.title = PAGE_TITLE[toRoute.name]
console.log(toRoute) // this lets you check what else is available to you here
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Concerns the documentation content or the documentation website
Projects
None yet
Development

No branches or pull requests

3 participants