Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'build' command in the template/config/typescript/package.json file may be incorrect. #393

Open
mishengqiang opened this issue Nov 29, 2023 · 2 comments

Comments

@mishengqiang
Copy link

mishengqiang commented Nov 29, 2023

When I execute the npm command npm run build -- --mode test, the "@" placeholder only accepts "test", and the "--mode" is missing.
image

When I modified the build command to "run-p type-check "build-only -- {@}" --" (added -- after build-only), executing the npm command npm run build -- --mode test was successful.
image

@mishengqiang mishengqiang changed the title The 'build' command in the template/config/typescript/package.json file may contain errors. The 'build' command in the template/config/typescript/package.json file may be incorrect. Nov 29, 2023
@cexbrayat
Copy link
Member

Hi @mishengqiang

Did you try to run npm run build-only -- --mode test directly?

But yeah, I think you're right it would be better.
Would you like to open a PR to fix? We would gladly review and merge it.

@mishengqiang
Copy link
Author

mishengqiang commented Nov 30, 2023

The npm run build-only -- --mode test command is correct; it aligns with the description in the Vite official documentation.

Sure, thank you for giving me the opportunity to submit a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants