Rework raw variables matching #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is dead code since the raw matchers cannot have literals anymore.
Instead of scanning raw variables lazily when evaluating rules, do it just after the AC pass. This is needed to make handling of process scanning (or scanning of multiple bytes slices in general) much easier.
The old VariableEvaluation was not really useful anymore.
This covers a one in Matcher::find_next_match_at which was not properly tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop evaluating raw variables lazily, and do it during (or rather, after) the ac pass. This allows simplifying quite a lot of code, and will make it much easier to add handling of more complex scan data (for example process memory).