Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ShareButton to components lib and place it in the feedback section #79

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Icaro-Nunes
Copy link
Contributor

What is the purpose of this pull request?

Move ShareButton to components lib and place it in the feedback section.

What problem is this solving?

Closes #73 .

Screenshots or example usage

2024-07-16-15-29-16.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for leafy-mooncake-7c2e5e ready!

Name Link
🔨 Latest commit 6db41f2
🔍 Latest deploy log https://app.netlify.com/sites/leafy-mooncake-7c2e5e/deploys/67115575cdd6090008eca650
😎 Deploy Preview https://deploy-preview-79--leafy-mooncake-7c2e5e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['release-no', 'release-auto', 'release-patch', 'release-minor', 'release-major']

@PedroAntunesCosta PedroAntunesCosta added the release-patch Patch version bump label Oct 17, 2024
Copy link
Contributor

@PedroAntunesCosta PedroAntunesCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Achei que ficou um pouco apertado aqui. Será que tem como diminuir ou tirar o share dependendo da tela? Se for complexo, talvez seja melhor despriorizar.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Patch version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementar botão de Share em todas as páginas de documentação
2 participants