Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/sidebar localized slugs #26

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Conversation

julia-rabello
Copy link
Collaborator

@julia-rabello julia-rabello commented Oct 4, 2024

Description

modifying the sidebar to support localized slugs introduced by vtexdocs/helpcenter#110 and vtexdocs/help-center-content#43

Testing

  1. clone helpcenter and checkout this branch

  2. change L31 of package.json on helpcenter to:

        "@vtexdocs/components": "https://github.com/vtexdocs/components.git#feat/sidebar-localized-slugs",
  3. run yarn install

  4. run yarn dev

⚠️ not tested with devportal yet

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['release-no', 'release-auto', 'release-patch', 'release-minor', 'release-major']

@julia-rabello julia-rabello added the release-patch Patch version bump label Oct 4, 2024
Copy link
Collaborator

@PedroAntunesCosta PedroAntunesCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@PedroAntunesCosta PedroAntunesCosta merged commit 13a5dff into main Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Patch version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants