Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devcontainer config #1215

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add devcontainer config #1215

wants to merge 1 commit into from

Conversation

silvadenisaraujo
Copy link
Contributor

What is the purpose of this pull request?

During our latest team session working on fixing the CORS issue we faced some issues to build the development environment. I would like to introduce here a devcontainer setup, where VSCode runs on top of a docker image, in this way we ensure that we are all building on top of the same environment without much struggles.

PS: I have tested with collima and works well.

What problem is this solving?

Streamline development environments, different node, yarn and tsc versions can cause delays during the development lifecycle.

How should this be manually tested?

Open the project on VSCode and check if you have the devcontainers extension configured, a modal will pop-up asking if you would like to run the code in a container, the container will spin-up and a terminal attached to it as well.

Screenshots or example usage

Example of the container running, you should see the following:

image

image

image

Types of changes

  • Refactor (non-breaking change that only makes the code better)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Chores checklist

  • [] Update CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants