Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document loading and disabled state in Menu #2014

Open
davicostalf opened this issue Oct 16, 2024 · 1 comment
Open

Document loading and disabled state in Menu #2014

davicostalf opened this issue Oct 16, 2024 · 1 comment
Labels
proposal Proposals for enhancements to the software

Comments

@davicostalf
Copy link
Contributor

davicostalf commented Oct 16, 2024

Problem

Menu uses the Button component as trigger, which includes a loading state. Initially we believed a Menu should not load, so this prop is not in the Menu documentation and is not present in the Figma library. However, this scenario made me believe that a loading state in the Menu could make sense:

Actions:
image

While importing:
image

@davicostalf davicostalf added the proposal Proposals for enhancements to the software label Oct 16, 2024
@davicostalf davicostalf changed the title Document loading state in Menu component Document loading and disabled state in Menu Oct 16, 2024
@davicostalf
Copy link
Contributor Author

We also need to document the disabled state, used while a container is loading. Once this state is added in Figma, it should be used in the loading Menu cell in the Table component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Proposals for enhancements to the software
Projects
Status: No status
Development

No branches or pull requests

1 participant