Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-hook-form peerDependencies to ^6.15.8 <7.0.0 #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eitoball
Copy link

@eitoball eitoball commented Nov 17, 2021

What problem is this solving?

It seems than react-hook-form v4.x doesn't handle number or integer values well. For example, radio button with integer value always fails with __form_error_notInteger__. Updating react-hook-form seems to solve this problem.

The latest of react-hook-form is 7.x, but updating to version 7 from version 4 seems to be too much work. So, I decided to update to 6.x first.

Checklist/Reminders

  • Updated README.md.
  • Updated CHANGELOG.md.
  • Linked this PR to a Clubhouse story (if applicable).
  • Updated/created tests (important for bug fixes).
  • Deleted the workspace after merging this PR (if applicable).

Example usage

Type of changes

✔️ Type of Change
_ Bug fix
_ New feature
✔️ Breaking change
✔️ Technical improvements

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants