Add prometheus app name to runtime metrics #511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
1 - Upgrade prom-client to newest version
2 - Add prometheus app name to runtime metrics
What problem is this solving?
Enable runtime http metrics aggregation by app
How should this be manually tested?
1 -
yarn link
Inside node-vtex-api src dir2 -
yarn link @vtex/api
at any app node dir of any IO node app, example:vtex.messages
3 -
vtex link
IO app4 - see metrics at grafana or by forwarding linked pod to your localhost and accessing
http://localhost:5050/metrics
Screenshots or example usage
Metrics usage example
Port forwarding & metrics exposure usage example
Types of changes