Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus app name to runtime metrics #511

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Jeymisson
Copy link
Contributor

@Jeymisson Jeymisson commented Jun 30, 2022

What is the purpose of this pull request?

1 - Upgrade prom-client to newest version
2 - Add prometheus app name to runtime metrics

What problem is this solving?

Enable runtime http metrics aggregation by app

How should this be manually tested?

1 - yarn link Inside node-vtex-api src dir
2 - yarn link @vtex/api at any app node dir of any IO node app, example: vtex.messages
3 - vtex link IO app
4 - see metrics at grafana or by forwarding linked pod to your localhost and accessing http://localhost:5050/metrics

Screenshots or example usage

Metrics usage example
Captura de Tela 2022-06-30 às 19 32 09

Port forwarding & metrics exposure usage example
Captura de Tela 2022-06-30 às 19 03 01

Captura de Tela 2022-06-30 às 19 02 30

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@Jeymisson Jeymisson requested a review from a team June 30, 2022 22:37
Copy link
Contributor

@arturpimentel arturpimentel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants