Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed El Salvador (SLV) locality list structure and fields. #622

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

kaio-donadelli
Copy link
Contributor

@kaio-donadelli kaio-donadelli commented Oct 30, 2024

Tracked in LOC-17258.

This breaks previously saved addresses, but CX/SA leadership in Mexico has confirmed this has been agreed upon with all customers in the region.

What is the purpose of this pull request?

To make address-form conform to new regulatory requirements in El Salvador on the country's administrative division.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@kaio-donadelli kaio-donadelli requested a review from a team as a code owner October 30, 2024 21:40
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 30, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@jeffersontuc jeffersontuc merged commit a9301e7 into main Oct 30, 2024
53 of 55 checks passed
@jeffersontuc jeffersontuc deleted the fix-SLV branch October 30, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants