Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the rules for France (FRA) so the number field is shown to users. #608

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Changed the rules for France (FRA) so the number field is shown to users. #608

merged 1 commit into from
Sep 19, 2024

Conversation

kaio-donadelli
Copy link
Contributor

@kaio-donadelli kaio-donadelli commented Sep 13, 2024 •
edited by jira bot
Loading

Tracked in LOC-16220.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@kaio-donadelli kaio-donadelli requested a review from a team as a code owner September 13, 2024 10:33
@vtex-io-ci-cd VTEX IO CI/CD
Copy link
Contributor

vtex-io-ci-cd bot commented Sep 13, 2024 •
edited by kaio-donadelli
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

sheilagomes
sheilagomes approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@sheilagomes sheilagomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffersontuc jeffersontuc merged commit bcb6f4b into main Sep 19, 2024
52 of 54 checks passed
@jeffersontuc jeffersontuc deleted the fix/FRA-number-field branch September 19, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmarcosp vmarcosp vmarcosp approved these changes

@sheilagomes sheilagomes sheilagomes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaio-donadelli @vmarcosp @sheilagomes @jeffersontuc