Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add autoUpperCase rule for alphanumerical postalCode countries #599

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

beatrizmaselli
Copy link
Contributor

What is the purpose of this pull request?

Today for alphanumeric postalCodes when typing the postalCode in lowerCase the UI invalidates the postalCode example for Ireland:

Screen.Recording.2024-07-12.at.17.13.27.mov

What problem is this solving?

After this change the rule autoUpperCase can be used to force the upper case on a specific field depending on the country by default when not set it will not affect the currently behavior.

How should this be manually tested?

Link the app and you can use the my account of dunnes:
https://addprod--dunnesstoresqa.myvtex.com/checkout/cart/add/?sku=24976&qty=1&seller=1&sc=4&sku=24368&qty=1&seller=1&sc=4&sku=23472&qty=1&seller=1&sc=4

Screenshots or example usage

Behavior varying by country rule:

Screen.Recording.2024-07-17.at.12.59.08.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@beatrizmaselli beatrizmaselli requested a review from a team as a code owner July 17, 2024 11:08
Copy link
Contributor

vtex-io-ci-cd bot commented Jul 17, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@jeffersontuc
Copy link
Contributor

Thanks for the contribution! 🙏🏽
Just rebased it with main

@beatrizmaselli
Copy link
Contributor Author

beatrizmaselli commented Jul 29, 2024

Thanks for the contribution! 🙏🏽 Just rebased it with main

Hello @jeffersontuc! How are you?

I believe this branch is up to date:
image

Let me know if something is needed at my end :)

@jeffersontuc jeffersontuc merged commit f48ebb8 into main Jul 29, 2024
23 of 25 checks passed
@jeffersontuc jeffersontuc deleted the feat/add-autoUpperCase-rule branch July 29, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants