Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hungary country rules and placeholder #553

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Add Hungary country rules and placeholder #553

merged 3 commits into from
Jan 25, 2024

Conversation

sheilagomes
Copy link
Contributor

@sheilagomes sheilagomes commented Dec 21, 2023 •
edited
Loading

Add Hungary country rules and placeholder. Tracked in task LOC-13198.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vtex-io-ci-cd VTEX IO CI/CD
Copy link
Contributor

vtex-io-ci-cd bot commented Dec 21, 2023 •
edited by sheilagomes
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@sheilagomes sheilagomes marked this pull request as ready for review January 12, 2024 14:12
@sheilagomes sheilagomes requested a review from a team as a code owner January 12, 2024 14:12
kaio-donadelli
kaio-donadelli approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@kaio-donadelli kaio-donadelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sheilagomes sheilagomes merged commit b9a4829 into main Jan 25, 2024
53 of 55 checks passed
@sheilagomes sheilagomes deleted the add/hungary branch January 25, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evertonstrack evertonstrack evertonstrack approved these changes

@vmarcosp vmarcosp vmarcosp approved these changes

@kaio-donadelli kaio-donadelli kaio-donadelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sheilagomes @evertonstrack @vmarcosp @kaio-donadelli