Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mojo::URL for urls #28

Open
incognico opened this issue May 21, 2020 · 0 comments
Open

Mojo::URL for urls #28

incognico opened this issue May 21, 2020 · 0 comments
Assignees
@vsTerminus

Comments

@incognico
Copy link
Contributor

Mojo-Discord/lib/Mojo/Discord/Gateway.pm

Line 314 in 51d15e1

$url .= "?v=" . $self->gateway_version . "&encoding=" . $self->gateway_encoding;

Here Mojo::URL could be used to build the URL instead of string concat. Same in REST.pm. In REST.pm there are/will also functions which take query string params.
@vsTerminus vsTerminus self-assigned this Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsTerminus vsTerminus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vsTerminus @incognico