bump puppetlabs_spec_helper + add needed dependency #319
Conversation
|
Have you reviewed how the output looks? See voxpupuli/puppet-collectd#633 where I ran some tests against collectd. It's fine when everything is green, but when there are errors, it's ... not pretty. |
|
In my opinion this is okay. It is harder to read, yes, but the speed gain is huge. We can still run the tests without parallel if it gets to ugly for debugging. |
bastelfreak
changed the title
|
puppetlabs_spec_helper got released so in theorie we could merge. |
| @@ -17,7 +17,8 @@ Gemfile: | |||
| required: | |||
| ':test': | |||
| - gem: puppetlabs_spec_helper | |||
| version: '~> 1.2.2' | |||
| version: '~> 2.0.1' | |||
| - gem: parallel_tests | |||
There was a problem hiding this comment.
i don't understand why this gem isn't just a transitive dependency that we don't have to care for, because puppetlabs_spec_helper depends on it.
There was a problem hiding this comment.
|
Ah, an earlier draft of the feature made the test target always run in parallel, which was my concern. Glad it's optional. |
I tested this locally with puppet-zabbix. Works great so far, spec tests run now in parallel. However we should hold of with merging, puppetlabs_spec_helper seems to be broken in certain situations. puppetlabs/puppetlabs_spec_helper#177