New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement check of git:// urls in metadata.json / .travis.yml #635

Open

bastelfreak opened this issue Jan 26, 2020 · 0 comments

Labels

Member

bastelfreak commented Jan 26, 2020

In our review guidelines we defined:

Is another module added as a dependency? Add it to the .fixtures.yml file as a git repository (as a https:// link, not ssh or git://). Spec tests always run against master branches to detect breaking changes as early as possible. Acceptance tests use the last release (installed by install_module_dependencies which parses it from the metadata.json)

This also applies for the source attribute in the metadata.json. I would be very helpful to have a linter plugin that validues those URLs.

The text was updated successfully, but these errors were encountered:

bastelfreak added the needs-feedback label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment