-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nomadic buildbot #198
Closed
Closed
nomadic buildbot #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classabbyamp
force-pushed
the
transformers
branch
from
July 6, 2024 19:27
83ef9fc
to
a0e5e4e
Compare
the-maldridge
requested changes
Jul 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass review, mostly a lot of surface items or things that need clarification.
classabbyamp
force-pushed
the
transformers
branch
3 times, most recently
from
July 13, 2024 18:43
e12ec4a
to
c8713c7
Compare
classabbyamp
force-pushed
the
transformers
branch
5 times, most recently
from
July 14, 2024 19:25
e1fded5
to
34cc6cb
Compare
This comment was marked as resolved.
This comment was marked as resolved.
classabbyamp
force-pushed
the
transformers
branch
2 times, most recently
from
August 5, 2024 13:42
6d15e9e
to
06e7299
Compare
classabbyamp
force-pushed
the
transformers
branch
5 times, most recently
from
September 28, 2024 17:12
0451a21
to
9c6425d
Compare
classabbyamp
force-pushed
the
transformers
branch
4 times, most recently
from
September 28, 2024 20:21
ba8b5b7
to
fc671e3
Compare
classabbyamp
force-pushed
the
transformers
branch
from
September 29, 2024 01:00
fc671e3
to
b406c1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs:
closes #133
secrets changes
buildsync
need to migrate secrets from vault to nomad:
buildbot
create/migrate secrets: