Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pending optimizations on Arbo #1086

Open
p4u opened this issue Sep 4, 2023 · 0 comments
Open

pending optimizations on Arbo #1086

p4u opened this issue Sep 4, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@p4u
Copy link
Member

p4u commented Sep 4, 2023

During the Arbo refactor performed on this PR #1080 I realized of two potential optimizations that could be made to increase speed on Add/Delete and Update methods.

  1. Instead of removing the intermediate orphan nodes SYNC (after the up() operation), it could be done ASYNC. The only thing we need to care about is to find a mechanism that can recover the list of nodes to remove after a program forced stop.

  2. When deleting recursively calling deleteWithTx() the orphan nodes (to later on add them again in the correct place). Instead of starting from the current Root we could execute the delete on a subtree, where the root is the current neighbour node.

@p4u p4u added the enhancement New feature or request label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant