Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument handling #405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix argument handling #405

wants to merge 1 commit into from

Conversation

rsommer
Copy link

@rsommer rsommer commented Dec 21, 2023

The key part of the argument handling has to be right after args, otherwise you'd get an AttributeError when trying to call encode on the args object.

Traceback (most recent call last):
  File "/tmp/tmp.VR4pSjeDta/vsphere-automation-sdk-python/samples/vsphere/vcenter/certificatemanagement/replace_tls_certificate.py", line 63, in <module>
    key = args.encode(encoding='utf-8').key.decode('unicode_escape')
AttributeError: 'Namespace' object has no attribute 'encode'

@rsommer rsommer requested a review from a team as a code owner December 21, 2023 12:38
@vmwclabot
Copy link
Member

@rsommer, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

The `key` part of the argument handling has to be right after `args`, otherwise you'd get an `AttributeError` when trying to call `encode` on the `args` object.

Signed-off-by: Roland Sommer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants