Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make timeout(s) for VM GuestOSShutdown in spec.PowerOffMode, spec.restartMode and spec.suspendMode configurable #179

Open
randomvariable opened this issue Jul 14, 2023 · 0 comments

Comments

@randomvariable
Copy link

Please describe the solution you would like.

In line with adding support for trySoft power off mode in Cluster API Provider vSphere in kubernetes-sigs/cluster-api-provider-vsphere#1982, for parity, we would like to have the timeout configurable for powerOffMode in particular.

This is because for certain (poorly behaved?) workloads, more than five minutes may be required to close down before a guest shutdown can occur. Allowing the timeout to be configurable would allow operators to choose something appropriate for their workload to strike a balance between fast shutdowns and avoiding data loss.

Is there anything else you would like to add?

Please tell us about your environment.

N/A

Value How to Obtain
Supervisor version rpm -qa VMware-wcp on the vCenter appliance
Supervisor node image version rpm -qa VMware-wcpovf on the vCenter appliance
Kubernetes version kubectl version
VM Operator version
kubectl -n vmware-system-vmop get pods \
  -ojsonpath='{range .items[*].spec.containers[*]}{.image}{"\n"}{end}' | \
  sort -u | \
  grep vmop | \
  awk -F'/' '{print $3}' | \
  awk -F: '{print $2}'
@randomvariable randomvariable changed the title Make timeout(s) of trySoft in spec.PowerOffMode, and optionally spec.restartMode and spec.suspendMode Make timeout(s) of trySoft in spec.PowerOffMode, and optionally spec.restartMode and spec.suspendMode configurable Jul 14, 2023
@srm09 srm09 changed the title Make timeout(s) of trySoft in spec.PowerOffMode, and optionally spec.restartMode and spec.suspendMode configurable Make timeout(s) for VM GuestOSShutdown in spec.PowerOffMode, spec.restartMode and spec.suspendMode configurable Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant