Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the log level to warning if templating of bootstrap data fails #147

Open
aruneshpa opened this issue May 10, 2023 · 0 comments
Open

Comments

@aruneshpa
Copy link
Contributor

What steps did you take and what happened?

The customization code performs any template substitutions in the metadata specified via the Secret/ConfigMap resource. If the template parsing encounters an error, we log the message at severity = error. However, it is possible that the bootstrap data contains special markers (e.g., {{) that trigger the template substitution logic. In those cases, users will see error messages in VM operator log that are not really an error and definitely not actionable.

A typical example for this would be users specifying user-data that contains {{ which is expected to be consumed by the guest as-is. However, since the current code treats the {{ as a template prefix, it will try to parse the template and log an error.

What did you expect to happen?

Ideally, we should only perform template substitutions for vAppConfig bootstrap type. This is handled by #46. However, we should also change the log level to Warning severity so as to cause less confusion. This issue deals focuses on the latter problem.

Is there anything else you would like to add?

N/A

Please tell us about your environment.

This issue has existed as far as I can go back in the history of VM operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@aruneshpa and others