Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

zshippable in minor versions cause upgrade to fail #4379

Open
adduarte opened this issue Feb 14, 2023 · 0 comments
Open

zshippable in minor versions cause upgrade to fail #4379

adduarte opened this issue Feb 14, 2023 · 0 comments
Labels
area/addons kind/bug PR/Issue related to a bug

Comments

@adduarte
Copy link

Bug description
adduarte
Member

During dev testing of cluster upgrade functionality, some of the package versions could have a non-numberic postfix, like "-zshippable".

The clusterbootstrap webhook incorrectly decides a version string like "0.12.1+vmware.2-tkg.2-zshippable" is a newer version than "0.12.1+vmware.2-tkg.3" becuase any non-number minor version (2-zshippable) is newer than a number version ("3")
thus the webhook sees "0.12.1+vmware.2-tkg.2-zshippable" is a newer version than "0.12.1+vmware.2-tkg.3", causing upgrade to fail.
Affected product area (please put an X in all that apply)

  • ( ) APIs
  • (x ) Addons
  • ( ) CLI
  • ( ) Docs
  • ( ) IAM
  • ( ) Installation
  • ( ) Plugin
  • ( ) Security
  • ( ) Test and Release
  • ( ) User Experience
  • ( ) Developer Experience

Expected behavior

Steps to reproduce the bug

Version (include the SHA if the version is not obvious)

Environment where the bug was observed (cloud, OS, etc)

Relevant Debug Output (Logs, manifests, etc)

@adduarte adduarte added kind/bug PR/Issue related to a bug needs-triage Indicates an issue or PR needs to be triaged labels Feb 14, 2023
@codegold79 codegold79 added area/addons and removed needs-triage Indicates an issue or PR needs to be triaged labels Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/addons kind/bug PR/Issue related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants