-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loader image too easily missed #13
Comments
given the long wait times it would be really lovely if we could get an indication of how long it would take. Also the spinning wheel does not stop spinning if something crashes or timeouts, so it's of no indication whatsoevver |
I expanded the angular app to display error messages. If for example an exception is thrown while processing the trace, and it has an error message, it will now be displayed, and the spinner stops. I'll redeploy tonight, let's see if that is better |
any chance we can get an actual progress bar with some indication how long it might take? |
Advanced. What is unclear to me is how to deliver the progress over HTTP. We would need some kind of streaming http request (web socket?). Is that supported on IE? The trace tree is cached in memory. Assuming that the parsing takes the most time, this is only needed the first time. We could get around that by loading the trace tree into the cache as soon as the log file is sent to vmprof.com, not when it is requested. Other than that, the requests should only transform parts of the tree to json. Parsing is required only once. @fijal can you tell me what action takes the most time? the first load of the page? clicking traces? the latter would only need some refactoring in JS |
What took the most time for us was loading the huge profile JSON blob from the SQL database. Not sure if you're having the same problem. My guess is that it's not a download speed problem, but a server performance one. (This is of course easily checked with Chrome Web Debugger etc.) Pure download progress can be easily achieved with the |
http://vmprof.com/static/images/loader.gif is too easily missed when we click somewhere in the page, and it's the only feedback that we actually clicked and have to wait. Worse, it might be completely off the page if we scroll down before clicking.
The text was updated successfully, but these errors were encountered: