Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRC calculation #6

Open
AT0myks opened this issue Apr 13, 2023 · 0 comments
Open

CRC calculation #6

AT0myks opened this issue Apr 13, 2023 · 0 comments

Comments

@AT0myks
Copy link
Contributor

AT0myks commented Apr 13, 2023

Another finding from testing. calc_crc returns a wrong result for a significant number of files. The summary is:

Before the last 2 PRs:

  • 4 errors (RLN36)
  • 58 ok
  • 356 bad

Now:

  • 0 errors
  • 61 ok
  • 357 bad

The section count fix only helped in 3 cases.

Here are the results in case they're useful. The keys are the sha256 of the PAK file. crc32 is the CRC from the file and calc_crc the result from the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant