Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Persistence] Organization / Unit / Context / etc. Names Should Be Unique #42

Open
wwerner opened this issue Sep 27, 2019 · 4 comments
Open

Comments

@wwerner
Copy link
Contributor

wwerner commented Sep 27, 2019

Currently creating organizations, units and contexts with the resp. same name is possible.
This can lead to them not being distinguishable from the UI. We could either also show the resp. IDs (but Users having to compare UUIDs is probably not the UX we're aiming for) or constrain the names to have to be unique.

Currently, this is possible:
image

image

@VaughnVernon
Copy link
Contributor

They should be unique. I think there are issues with unique constraints on HSQLDB and I may have relaxed those initially for the sake of progress. HSQLDB is not the production database, it is only for development. I think this needs to remain as an issue to ensure it is addressed, but for now let's not be concerned about it for the sake of progress.

@VaughnVernon VaughnVernon changed the title Q: Should Organization / Unit / Context Names be unique? [DB] Should Organization / Unit / Context Names be unique? Sep 28, 2019
@VaughnVernon VaughnVernon changed the title [DB] Should Organization / Unit / Context Names be unique? [Persistence] Should Organization / Unit / Context Names be unique? Sep 28, 2019
@VaughnVernon VaughnVernon changed the title [Persistence] Should Organization / Unit / Context Names be unique? [Persistence] Organization / Unit / Context / etc. Names Should Be Unique Sep 28, 2019
@Florian-Schoenherr
Copy link
Contributor

This is mitigated by the new details-toggle.
details on tree
details on select
If so desired, we could warn before someone creates with a non-unique name (because id's still look pretty ugly).

@VaughnVernon
Copy link
Contributor

@Florian-Schoenherr We will address this in a later version. We will be creating a separate backlog so leave this open and remember it for later inclusion.

@Florian-Schoenherr
Copy link
Contributor

Another id I had was to ditch ids completely and have the names be unique. That way people would use:
GET /organizations/org/units/unit/contexts/context/schemas/schema/1.0.0.
But that would require more changes. Let's keep this open, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants