vsl: update include and lib paths for openmpi

[kimshrier]

On FreeBSD, the openmpi package gets installed in /usr/local/mpi/openmpi instead of /usr/local. Therefore the include and lib paths need to include -I/usr/local/mpi/openmpi/include and -L/usr/local/mpi/openmpi/lib.

I notice that if one uses the mpich package instead of openmpi, the headers and library are in /usr/local/include and /usr/local/lib. Then one does not need to make changes to mpi/_cflags.c.v. However, with mpich, you need to change the types of MPI_Comm and MPI_Group as shown in the following diff.

diff --git a/mpi/mpi.c.v b/mpi/mpi.c.v
index b6074401..323096c0 100644
--- a/mpi/mpi.c.v
+++ b/mpi/mpi.c.v
@@ -6,9 +6,9 @@ fn C.MPI_Initialized(flag &int) int
 fn C.MPI_Init(argc int, argv &charptr) int
 fn C.MPI_Init_thread(argc int, argv &charptr, required int, provided &int) int
 
-type MPI_Comm = voidptr
+type MPI_Comm = int
 type MPI_Datatype = voidptr
-type MPI_Group = voidptr
+type MPI_Group = int
 type MPI_Status = voidptr
 type MPI_Op = voidptr
 
@@ -88,7 +88,7 @@ mut:
 pub fn Communicator.new(ranks []int) !&Communicator {
        mut o := &Communicator{
                comm: MPI_Comm(C.MPI_COMM_WORLD)
-               group: unsafe { nil }
+               group: 0
        }
        if ranks.len == 0 {
                C.MPI_Comm_group(C.MPI_COMM_WORLD, &o.group)

VSL works with mpich after making this patch.

Summary by CodeRabbit

• Refactor
  • Updated system-specific include and library paths to enhance compatibility with Linux and FreeBSD.

[coderabbitai]

Walkthrough

The recent revisions focus on updating the compiler flags within the mpi project to ensure compatibility with different operating systems. These adjustments cater specifically to the nuances of Linux and FreeBSD environments, optimizing the way the project includes headers and links libraries.

Changes

File	Summary
mpi/_cflags.c.v	Updated include and library paths for Linux and FreeBSD compatibility.

🐇
In the realm of code, where compilers tread,
Paths now untwined, the updates spread.
Across Linux and FreeBSD, the flags do dance,
A hop of success in the code's vast expanse. 🎉
🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 57dc598 and da797a9.

Files selected for processing (1)

• mpi/_cflags.c.v (1 hunks)

Additional comments: 2

mpi/_cflags.c.v (2)

• 5-5: The include path for FreeBSD has been updated to add the openmpi specific directory before the standard /usr/local/include. This ensures that the openmpi headers are found before the system headers, which is necessary for compatibility.

• 6-6: The library path for FreeBSD has been updated to include the openmpi specific library path at the beginning. This change is consistent with the include path change and is necessary for linking against the correct openmpi libraries.

[spytheman]

Thank you.
Excellent analysis.