Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcl: more error descriptions #189

Merged
merged 1 commit into from
Nov 2, 2023
Merged

vcl: more error descriptions #189

merged 1 commit into from
Nov 2, 2023

Conversation

Eliyaan
Copy link
Contributor

@Eliyaan Eliyaan commented Nov 1, 2023

Adds a few more error descriptions for vcl.

This is my first PR on vsl I hope I've done it well.

Summary by CodeRabbit

New Features:

  • Added a range of new error codes to the VCL library, enhancing the system's ability to identify and communicate specific issues. This will help users diagnose and resolve problems more effectively. The new error codes cover a variety of potential issues, including program compilation failures, unavailable linkers, device partition failures, and more.

Copy link

coderabbitai bot commented Nov 1, 2023

Walkthrough

The VCL library has been enhanced with the addition of new error codes and corresponding error messages. These changes are aimed at providing more detailed and specific error information to users, improving the debugging process. The changes are confined to the error handling part of the library and do not affect any other areas.

Changes

File Summary
vcl/errors.c.v New error codes and corresponding error messages added. These include err_compile_program_failure, err_linker_not_available, err_link_program_failure, err_device_partition_failed, err_kernel_arg_info_not_available, err_invalid_image_descriptor, err_invalid_compiler_options, err_invalid_linker_options, err_invalid_device_partition_count, err_invalid_pipe_size, err_invalid_device_queue, err_invalid_spec_id, and err_max_size_restriction_exceeded. No changes to the signatures of exported functions, global data structures, global variables, interfaces, return values, or thrown exceptions.

🐇🍂

As the leaves fall, we code away,

Adding error codes, making a better day.

No more confusion, no more dismay,

With clear messages, we light the way.

In this season of harvest and hay,

We celebrate our progress, hip hip hurray!

So here's to the changes, come what may,

With every new line, we're here to stay. 🎉🍁


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 5453f1d and f686b2d.
Files selected for processing (1)
  • vcl/errors.c.v (3 hunks)
Files skipped from review due to trivial changes (1)
  • vcl/errors.c.v

Copy link
Member

@ulises-jeremias ulises-jeremias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ulises-jeremias ulises-jeremias merged commit 5359bb0 into vlang:main Nov 2, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants